You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/07 13:00:39 UTC

[PR] test(config): cover the deprecated static mock flag [rocketmq-dashboard]

yyqdbngt opened a new pull request, #4070:
URL: https://github.com/apache/rocketmq-dashboard/pull/4070

   Fixes #4010
   
   
   ## Summary
   
   Add a regression test in `web/src/config.test.ts` that locks the deprecated static mock flag `USE_MOCK` (exported by `web/src/config.ts`) to `false` for the current Studio runtime.
   
   ## Why
   
   `USE_MOCK` is kept only for backward compatibility, but the existing `config.test.ts` covered `API_BASE_URL` exclusively. The deprecated flag was unprotected, so it could be accidentally flipped and silently reintroduce the legacy mock-data code path. A focused Vitest case now fails if the flag changes.
   
   ## Testing
   
   - `cd web && ./node_modules/.bin/tsc -b tsconfig.app.json` — passes (exit 0)
   - `./node_modules/.bin/vitest run src/config.test.ts` — all tests green
   - `git diff --check` — clean
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test(config): cover the deprecated static mock flag [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #4070: test(config): cover the deprecated static mock flag
URL: https://github.com/apache/rocketmq-dashboard/pull/4070


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org