You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/12 08:53:38 UTC
Review Request 39218: Windows: Added support for
`process/address.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39218/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `process/address.hpp`.
Diffs
-----
3rdparty/libprocess/include/process/address.hpp bf230ac1a401284f4d4abdbaa53f5b8b9d83c000
Diff: https://reviews.apache.org/r/39218/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39218: Windows: Added support for
`process/address.hpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39218/#review103061
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/include/process/address.hpp (lines 19 - 23)
<https://reviews.apache.org/r/39218/#comment160919>
This conditional compilation jumping between sections seems a little weird.
Let's make each section explicit.
- Joris Van Remoortere
On Oct. 13, 2015, 6:35 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39218/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 6:35 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, and MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3629
> https://issues.apache.org/jira/browse/MESOS-3630
> https://issues.apache.org/jira/browse/MESOS-3631
> https://issues.apache.org/jira/browse/MESOS-3693
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `process/address.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/address.hpp bf230ac1a401284f4d4abdbaa53f5b8b9d83c000
>
> Diff: https://reviews.apache.org/r/39218/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39218: Windows: Added support for
`process/address.hpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39218/#review102520
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 13, 2015, 11:35 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39218/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 11:35 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, and MESOS-3693
> https://issues.apache.org/jira/browse/MESOS-3628
> https://issues.apache.org/jira/browse/MESOS-3629
> https://issues.apache.org/jira/browse/MESOS-3630
> https://issues.apache.org/jira/browse/MESOS-3631
> https://issues.apache.org/jira/browse/MESOS-3693
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Added support for `process/address.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/address.hpp bf230ac1a401284f4d4abdbaa53f5b8b9d83c000
>
> Diff: https://reviews.apache.org/r/39218/diff/
>
>
> Testing
> -------
>
> Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39218: Windows: Added support for
`process/address.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39218/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 6:35 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-3628, MESOS-3629, MESOS-3630, MESOS-3631, and MESOS-3693
https://issues.apache.org/jira/browse/MESOS-3628
https://issues.apache.org/jira/browse/MESOS-3629
https://issues.apache.org/jira/browse/MESOS-3630
https://issues.apache.org/jira/browse/MESOS-3631
https://issues.apache.org/jira/browse/MESOS-3693
Repository: mesos
Description
-------
Windows: Added support for `process/address.hpp`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/address.hpp bf230ac1a401284f4d4abdbaa53f5b8b9d83c000
Diff: https://reviews.apache.org/r/39218/diff/
Testing
-------
Built CMake solution and ran `make check` (or equivalent) on Windows 10, Ubuntu 15, OS X 10.10. Built autotools solution and ran `make check` on Ubuntu 15.
Thanks,
Alex Clemmer