You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/11/13 19:16:21 UTC

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #387: [SUREFIRE-1939] Fix NPE in SystemUtils.toJdkHomeFromJvmExec if java home has 2 components

slawekjaranowski commented on a change in pull request #387:
URL: https://github.com/apache/maven-surefire/pull/387#discussion_r748755474



##########
File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/SystemUtils.java
##########
@@ -88,7 +88,7 @@ public static boolean endsWithJavaPath( String jvmExecPath )
     public static File toJdkHomeFromJvmExec( String jvmExecutable )

Review comment:
       Do we have unit test for it ... ?
   If not please create - it should be easy 
   Unit test should coverage all cases described in java doc for this method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org