[GitHub] [airflow] mik-laj commented on a diff in pull request #22852: Add ability for Dataproc operator to create cluster in GKE cluster

[GitBox <gi...@apache.org>]

mik-laj commented on code in PR #22852:
URL: https://github.com/apache/airflow/pull/22852#discussion_r846088438


##########
airflow/providers/google/cloud/hooks/dataproc.py:
##########
@@ -292,7 +292,9 @@ def create_cluster(
         region: str,
         project_id: str,
         cluster_name: str,
-        cluster_config: Union[Dict, Cluster],
+        cluster_config: Union[Dict, Cluster, None],

Review Comment:
   ```suggestion
           cluster_config: Union[Dict, Cluster, None] = None,
   ```



##########
airflow/providers/google/cloud/hooks/dataproc.py:
##########
@@ -292,7 +292,9 @@ def create_cluster(
         region: str,
         project_id: str,
         cluster_name: str,
-        cluster_config: Union[Dict, Cluster],
+        cluster_config: Union[Dict, Cluster, None],
+        virtual_cluster_config: Optional[Dict] = None,
+        run_in_gke_cluster: Optional[bool] = False,

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org