You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/14 09:21:11 UTC

[GitHub] [flink] azagrebin opened a new pull request #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

azagrebin opened a new pull request #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851
 
 
   ## What is the purpose of the change
   
   As there is no strong consensus about using new 'shuffle' naming for memory config options. We decided to fallback to the the existing naming and use 'network' instead of 'shuffle'. We still keeping the new naming convention with prefix 'taskmanager.memory.*'.
   
   ## Brief change log
   
   Basically, we just need to rename 'taskmanager.memory.shuffle.' to 'taskmanager.memory.network.' as 'shuffle' naming has never been released and adjust docs/comments.
   
   ## Verifying this change
   
   trivial renaming
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs / JavaDocs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] xintongsong removed a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
xintongsong removed a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574133436
 
 
   Found occurrences of "taskmanager.memory.shuffle.*" in flink-dist/src/main/resources/flink-conf.yaml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574091020
 
 
   <!--
   Meta data
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144293016 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   -->
   ## CI report:
   
   * 99fb99e8d24f04ecfe63c06456673ac78d28a118 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144293016) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574091020
 
 
   <!--
   Meta data
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144293016 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:196246785d586826c0a93b353cb18185f3ed67af Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4336 TriggerType:PUSH TriggerID:196246785d586826c0a93b353cb18185f3ed67af
   Hash:196246785d586826c0a93b353cb18185f3ed67af Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144339563 TriggerType:PUSH TriggerID:196246785d586826c0a93b353cb18185f3ed67af
   -->
   ## CI report:
   
   * 99fb99e8d24f04ecfe63c06456673ac78d28a118 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144293016) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322) 
   * 196246785d586826c0a93b353cb18185f3ed67af Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144339563) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4336) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] azagrebin closed pull request #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
azagrebin closed pull request #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574082336
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 99fb99e8d24f04ecfe63c06456673ac78d28a118 (Tue Jan 14 09:25:55 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574091020
 
 
   <!--
   Meta data
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144293016 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:196246785d586826c0a93b353cb18185f3ed67af Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:196246785d586826c0a93b353cb18185f3ed67af
   -->
   ## CI report:
   
   * 99fb99e8d24f04ecfe63c06456673ac78d28a118 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144293016) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322) 
   * 196246785d586826c0a93b353cb18185f3ed67af UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574091020
 
 
   <!--
   Meta data
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   -->
   ## CI report:
   
   * 99fb99e8d24f04ecfe63c06456673ac78d28a118 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] azagrebin commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574702288
 
 
   Thanks for the reviews @tillrohrmann @xintongsong 
   merged into master by 7513d9b184feffdcb6e0c09d1b74f8de21a98e81
   merged into 1.10 by a6023e6953189ece1bb8fbb7bc3e117172ad5264

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] xintongsong commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
xintongsong commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574133436
 
 
   Found occurrences of "taskmanager.memory.shuffle.*" in flink-dist/src/main/resources/flink-conf.yaml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574091020
 
 
   <!--
   Meta data
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144293016 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   -->
   ## CI report:
   
   * 99fb99e8d24f04ecfe63c06456673ac78d28a118 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144293016) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574091020
 
 
   <!--
   Meta data
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144293016 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:196246785d586826c0a93b353cb18185f3ed67af Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4336 TriggerType:PUSH TriggerID:196246785d586826c0a93b353cb18185f3ed67af
   Hash:196246785d586826c0a93b353cb18185f3ed67af Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144339563 TriggerType:PUSH TriggerID:196246785d586826c0a93b353cb18185f3ed67af
   -->
   ## CI report:
   
   * 99fb99e8d24f04ecfe63c06456673ac78d28a118 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144293016) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322) 
   * 196246785d586826c0a93b353cb18185f3ed67af Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144339563) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4336) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] azagrebin commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574189913
 
 
   Thanks for the reviews @tillrohrmann @xintongsong 
   Indeed, now I also replaced "memory.shuffle" with "memory.network"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574091020
 
 
   <!--
   Meta data
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/144293016 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:99fb99e8d24f04ecfe63c06456673ac78d28a118 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322 TriggerType:PUSH TriggerID:99fb99e8d24f04ecfe63c06456673ac78d28a118
   Hash:196246785d586826c0a93b353cb18185f3ed67af Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4336 TriggerType:PUSH TriggerID:196246785d586826c0a93b353cb18185f3ed67af
   Hash:196246785d586826c0a93b353cb18185f3ed67af Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/144339563 TriggerType:PUSH TriggerID:196246785d586826c0a93b353cb18185f3ed67af
   -->
   ## CI report:
   
   * 99fb99e8d24f04ecfe63c06456673ac78d28a118 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/144293016) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4322) 
   * 196246785d586826c0a93b353cb18185f3ed67af Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/144339563) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4336) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] azagrebin commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names

Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #10851: [FLINK-15517][Runtime][Configuration][Network] Use back 'network' in 'shuffle' memory config option names
URL: https://github.com/apache/flink/pull/10851#issuecomment-574080279
 
 
   cc @xintongsong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services