You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mxm <gi...@git.apache.org> on 2016/05/26 10:19:20 UTC

[GitHub] flink pull request: [FLINK-3972] subclasses of ResourceID may not ...

GitHub user mxm opened a pull request:

    https://github.com/apache/flink/pull/2037

    [FLINK-3972] subclasses of ResourceID may not to be serializable

    WorkerTypes are currently subclasses of ResourceID. ResourceID implements Serializable but not necessarily its subclasses. This may lead to problems when these subclasses are used as ResourceIDs, i.e. serialization may fail with NotSerializableExceptions. Currently, subclasses are never send over the wire but they might be in the future.
    
    Instead of relying on subclasses of ResourceID for the WorkerTypes, we can let them implement an interface to retrieve the ResourceID of a WorkerType.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mxm/flink FLINK-3972

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2037.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2037
    
----
commit c9dc0fe52625d4d455a9305976c644c10bf877ea
Author: Maximilian Michels <mx...@apache.org>
Date:   2016-05-25T15:20:34Z

    [FLINK-3972] subclasses of ResourceID may not to be serializable
    
    WorkerTypes are currently subclasses of ResourceID. ResourceID
    implements Serializable but not necessarily its subclasses. This may
    lead to problems when these subclasses are used as ResourceIDs,
    i.e. serialization may fail with NotSerializableExceptions. Currently,
    subclasses are never send over the wire but they might be in the future.
    
    Instead of relying on subclasses of ResourceID for the WorkerTypes, we
    can let them implement an interface to retrieve the ResourceID of a
    WorkerType.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3972] subclasses of ResourceID may not ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2037


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3972] subclasses of ResourceID may not ...

Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/2037#issuecomment-222113016
  
    Rebased to the latest master. Will merge once the tests pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---