You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/11/06 13:32:36 UTC
[PR] fix(r/adbcsqlite): Allow sqlite driver to link against sqlite3 that does not contain sqlite3_load_extension() [arrow-adbc]
paleolimbot opened a new pull request, #1259:
URL: https://github.com/apache/arrow-adbc/pull/1259
Closes #1255.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r/adbcsqlite): Allow sqlite driver to link against sqlite3 that does not contain sqlite3_load_extension() [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #1259:
URL: https://github.com/apache/arrow-adbc/pull/1259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r/adbcsqlite): Allow sqlite driver to link against sqlite3 that does not contain sqlite3_load_extension() [arrow-adbc]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #1259:
URL: https://github.com/apache/arrow-adbc/pull/1259#discussion_r1383424841
##########
r/adbcsqlite/configure:
##########
Review Comment:
I did check...it seems like a *very* Apple-specific modification that basically everybody has had a problem with (e.g., Python, GDAL).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(r/adbcsqlite): Allow sqlite driver to link against sqlite3 that does not contain sqlite3_load_extension() [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #1259:
URL: https://github.com/apache/arrow-adbc/pull/1259#discussion_r1383392846
##########
r/adbcsqlite/configure:
##########
Review Comment:
SQLite itself doesn't provide an ifdef? That's unfortunate
##########
c/driver/sqlite/sqlite.c:
##########
@@ -320,6 +321,12 @@ AdbcStatusCode SqliteConnectionSetOption(struct AdbcConnection* connection,
free(conn->extension_path);
conn->extension_path = NULL;
return ADBC_STATUS_OK;
+#else
+ SetError(error,
+ "[SQLite] This build of the ADBC SQLite driver does not support extension "
+ "loading");
+ return ADBC_STATUS_INTERNAL;
Review Comment:
nit: NOT_IMPLEMENTED?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org