You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ixtalo (JIRA)" <ji...@apache.org> on 2012/08/16 12:29:37 UTC

[jira] [Created] (WICKET-4714) mvn build fails in wicket-util in FileTest.java:171 on Windows

Ixtalo created WICKET-4714:
------------------------------

             Summary: mvn build fails in wicket-util in FileTest.java:171 on Windows
                 Key: WICKET-4714
                 URL: https://issues.apache.org/jira/browse/WICKET-4714
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.5.7
         Environment: MS Windows 7
            Reporter: Ixtalo
            Priority: Critical


This assertion fails on Windows for "mvn test" in FileText.java:171:
assertEquals("/file with whitespace", Files.getLocalFileFromUrl(url).getPath());

Suggestion:
assertEquals(File.separator + "file with whitespace", Files.getLocalFileFromUrl(url).getPath());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-4714) mvn build fails in wicket-util in FileTest.java:171 on Windows

Posted by "Ixtalo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436599#comment-13436599 ] 

Ixtalo commented on WICKET-4714:
--------------------------------

Yes, you are right, it has been fixed.

"Use File.separator instead of hardcoding it for Unix"
https://github.com/apache/wicket/commit/24390d662a9eb0e58ac54252383b93e38729dac7

                
> mvn build fails in wicket-util in FileTest.java:171 on Windows
> --------------------------------------------------------------
>
>                 Key: WICKET-4714
>                 URL: https://issues.apache.org/jira/browse/WICKET-4714
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.7
>         Environment: MS Windows 7
>            Reporter: Ixtalo
>            Priority: Minor
>              Labels: patch
>
> This assertion fails on Windows for "mvn test" in FileText.java:171:
> assertEquals("/file with whitespace", Files.getLocalFileFromUrl(url).getPath());
> Suggestion:
> assertEquals(File.separator + "file with whitespace", Files.getLocalFileFromUrl(url).getPath());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (WICKET-4714) mvn build fails in wicket-util in FileTest.java:171 on Windows

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4714.
-------------------------------------

    Resolution: Implemented
    
> mvn build fails in wicket-util in FileTest.java:171 on Windows
> --------------------------------------------------------------
>
>                 Key: WICKET-4714
>                 URL: https://issues.apache.org/jira/browse/WICKET-4714
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.7
>         Environment: MS Windows 7
>            Reporter: Ixtalo
>            Priority: Minor
>              Labels: patch
>
> This assertion fails on Windows for "mvn test" in FileText.java:171:
> assertEquals("/file with whitespace", Files.getLocalFileFromUrl(url).getPath());
> Suggestion:
> assertEquals(File.separator + "file with whitespace", Files.getLocalFileFromUrl(url).getPath());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (WICKET-4714) mvn build fails in wicket-util in FileTest.java:171 on Windows

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-4714:
------------------------------------

    Priority: Minor  (was: Critical)

I believe this is fixed in -SNAPSHOT but I have no access to my IDE at the moment.
                
> mvn build fails in wicket-util in FileTest.java:171 on Windows
> --------------------------------------------------------------
>
>                 Key: WICKET-4714
>                 URL: https://issues.apache.org/jira/browse/WICKET-4714
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.7
>         Environment: MS Windows 7
>            Reporter: Ixtalo
>            Priority: Minor
>              Labels: patch
>
> This assertion fails on Windows for "mvn test" in FileText.java:171:
> assertEquals("/file with whitespace", Files.getLocalFileFromUrl(url).getPath());
> Suggestion:
> assertEquals(File.separator + "file with whitespace", Files.getLocalFileFromUrl(url).getPath());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (WICKET-4714) mvn build fails in wicket-util in FileTest.java:171 on Windows

Posted by "Ixtalo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435908#comment-13435908 ] 

Ixtalo commented on WICKET-4714:
--------------------------------

Error message:

Failed tests:   fileWithWhitespace(org.apache.wicket.util.file.FilesTest): expected:<[/]file with whitespace> but was:<[\]file with whitespace>
                
> mvn build fails in wicket-util in FileTest.java:171 on Windows
> --------------------------------------------------------------
>
>                 Key: WICKET-4714
>                 URL: https://issues.apache.org/jira/browse/WICKET-4714
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.7
>         Environment: MS Windows 7
>            Reporter: Ixtalo
>            Priority: Critical
>              Labels: patch
>
> This assertion fails on Windows for "mvn test" in FileText.java:171:
> assertEquals("/file with whitespace", Files.getLocalFileFromUrl(url).getPath());
> Suggestion:
> assertEquals(File.separator + "file with whitespace", Files.getLocalFileFromUrl(url).getPath());

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira