You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/05/10 21:13:37 UTC

Review Request: Cleaned up the allocator filter pointer issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11055/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

As per Ben M's request, I've modified the allocator to no longer store filters as pointers, because of the weird issues it created around when a filter could be deleted.

This patch depends on https://reviews.apache.org/r/6665/


Diffs
-----

  src/master/hierarchical_allocator_process.hpp 2422fbd 

Diff: https://reviews.apache.org/r/11055/diff/


Testing
-------

bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=1000 --gtest_filter=*Allocator*

with
https://reviews.apache.org/r/11033/
https://reviews.apache.org/r/10786/
applied


Thanks,

Thomas Marshall

Re: Review Request: Cleaned up the allocator filter pointer issues

Posted by Benjamin Hindman <be...@berkeley.edu>.

Hi Thomas,

It looks like we lost this review when we moved from SVN to git. Can you
resubmit?

Thanks!

Ben.


On Fri, May 10, 2013 at 12:13 PM, Thomas Marshall <tw...@gmail.com> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11055/
> -----------------------------------------------------------
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> As per Ben M's request, I've modified the allocator to no longer store
> filters as pointers, because of the weird issues it created around when a
> filter could be deleted.
>
> This patch depends on https://reviews.apache.org/r/6665/
>
>
> Diffs
> -----
>
>   src/master/hierarchical_allocator_process.hpp 2422fbd
>
> Diff: https://reviews.apache.org/r/11055/diff/
>
>
> Testing
> -------
>
> bin/mesos-tests.sh --gtest_break_on_failure --gtest_repeat=1000
> --gtest_filter=*Allocator*
>
> with
> https://reviews.apache.org/r/11033/
> https://reviews.apache.org/r/10786/
> applied
>
>
> Thanks,
>
> Thomas Marshall
>
>