You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/04 01:28:41 UTC
[GitHub] [skywalking] codecov-io commented on issue #4438: Support change
detection mechanism in DCS
codecov-io commented on issue #4438: Support change detection mechanism in DCS
URL: https://github.com/apache/skywalking/pull/4438#issuecomment-594265297
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4438?src=pr&el=h1) Report
> Merging [#4438](https://codecov.io/gh/apache/skywalking/pull/4438?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/85cc9c36ac40dc3a28788d90cc51d7e74c8acf0e?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `42.1%`.
[](https://codecov.io/gh/apache/skywalking/pull/4438?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4438 +/- ##
==========================================
+ Coverage 25.11% 25.13% +0.02%
==========================================
Files 1211 1211
Lines 28078 28088 +10
Branches 3864 3866 +2
==========================================
+ Hits 7052 7061 +9
- Misses 20377 20378 +1
Partials 649 649
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4438?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tion/zookeeper/ZookeeperConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4438/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLXpvb2tlZXBlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vem9va2VlcGVyL1pvb2tlZXBlckNvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4438/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...figuration/apollo/ApolloConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4438/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwb2xsby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBvbGxvL0Fwb2xsb0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...onfiguration/nacos/NacosConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4438/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLW5hY29zL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29uZmlndXJhdGlvbi9uYWNvcy9OYWNvc0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `72.54% <100%> (ø)` | :arrow_up: |
| [.../configuration/etcd/EtcdConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4438/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWV0Y2Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jb25maWd1cmF0aW9uL2V0Y2QvRXRjZENvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `66.66% <100%> (ø)` | :arrow_up: |
| [...ion/consul/ConsulConfigurationWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4438/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWNvbnN1bC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vY29uc3VsL0NvbnN1bENvbmZpZ3VyYXRpb25XYXRjaGVyUmVnaXN0ZXIuamF2YQ==) | `50.94% <100%> (ø)` | :arrow_up: |
| [...erver/configuration/api/ConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4438/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1dhdGNoZXJSZWdpc3Rlci5qYXZh) | `78.26% <68.42%> (-0.53%)` | :arrow_down: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4438/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4438?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4438?src=pr&el=footer). Last update [85cc9c3...96a60c4](https://codecov.io/gh/apache/skywalking/pull/4438?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services