You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/03/28 15:48:12 UTC
[GitHub] [hadoop] ben-roling commented on issue #646: HADOOP-16085: use
object version or etags to protect against inconsistent read after
replace/overwrite
ben-roling commented on issue #646: HADOOP-16085: use object version or etags to protect against inconsistent read after replace/overwrite
URL: https://github.com/apache/hadoop/pull/646#issuecomment-477653993
Really appreciate the review @noslowerdna ! I think I have addressed all of your comments now and I don't have any remaining TODOs on my own list. @steveloughran and @bgaborg I know this is kind of lengthy but if you can get a chance to review I will be really grateful! I'll be happy to address any suggestions you have for improvement.
I ran the full integration tests (minus -Ds3guard) yesterday and they passed with both fs.s3a.change.detection.source=etag and versionId. I don't think any changes I've made since would affect the result but I will run again anyway as well as with -Ds3guard.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org