[GitHub] [hbase] Apache9 commented on pull request #4622: HBASE-27201 Clean up error-prone findings in hbase-backup

[GitBox <gi...@apache.org>]

Apache9 commented on PR #4622:
URL: https://github.com/apache/hbase/pull/4622#issuecomment-1188521964

   > @Apache9 It is fine to handle the string split warnings some other way, but I thought I would take this approach. I had a bit of trouble actually using Splitter. I'm sure I could figure it out but there are other things that seem more important. string#split works in these cases and is good enough IMHO. Is this ok?
   > 
   > Or, we could just leave these in place and also not add the `@SuppressWarnings("StringSplitter")`, that is fine with me too. In other words, no change for the string#split cases.
   
   Usually there is no harm to use String.split, as long as it has been like this for a long time in our code base, so I'm OK with leaving it as is or adding a SuppressWarnings.
   Out of interest, what is the problem when using Splitter? It is just a Splitter.on().splitToList().
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org