[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Move Trigger implementations to Triggers.scala with proper deprecation/removal

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Move Trigger implementations to Triggers.scala with proper deprecation/removal
URL: https://github.com/apache/spark/pull/24996#discussion_r300846024
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
 ##########
 @@ -27,3 +32,34 @@ import org.apache.spark.sql.streaming.Trigger
 @Experimental
 @Evolving
 case object OneTimeTrigger extends Trigger
+
+/**
+ * A [[Trigger]] that runs a query periodically based on the processing time. If `interval` is 0,
+ * the query will run as fast as possible.
+ */
+@Evolving
+private[sql] case class ProcessingTimeTrigger(intervalMs: Long) extends Trigger {
 
 Review comment:
   I think you are moving the opposite direction from the way I recommended. Now, you add a new deprecate in this PR.
   ```
   @deprecated("use Trigger.Continuous(intervalMs)", "3.0.0")
   // NOTE: In later release, we can remove this.
   ```
   
   Why do you add that here? I'm -1 for this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org