You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/04/02 23:35:42 UTC
Review Request 45622: Fixed Nvidia GPU isolator build for gcc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45622/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and switched to 'mcypark'.
Bugs: MESOS-5082
https://issues.apache.org/jira/browse/MESOS-5082
Repository: mesos
Description
-------
There appears to be a discrepancy between clang and gcc, which allows
clang to accept `using` declarations of the form `using ns_name::name;`
that contain nested classes, structs, and enums after the `name` field
in the declaration (e.g. `using ns_name::name::enum;`).
The language for describing this functionality is ambiguous in the
C++11 specification as referenced here:
http://en.cppreference.com/w/cpp/language/namespace#Using-declarations
This patch fixes a bug where we relied on this functionality in clang
and had build errors in gcc.
Diffs
-----
src/linux/cgroups.hpp 53397fc1da11a71259df1c38526a613676a60301
src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp c2cdc8fde7a85741be6494ea664d3719d1f13a43
Diff: https://reviews.apache.org/r/45622/diff/
Testing
-------
Rebuilt with nvidia gpu support for both clang and gcc.
Thanks,
Kevin Klues
Re: Review Request 45622: Fixed Nvidia GPU isolator build for gcc.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45622/#review127231
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On April 2, 2016, 9:35 p.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45622/
> -----------------------------------------------------------
>
> (Updated April 2, 2016, 9:35 p.m.)
>
>
> Review request for mesos, Ben Mahler and switched to 'mcypark'.
>
>
> Bugs: MESOS-5082
> https://issues.apache.org/jira/browse/MESOS-5082
>
>
> Repository: mesos
>
>
> Description
> -------
>
> There appears to be a discrepancy between clang and gcc, which allows
> clang to accept `using` declarations of the form `using ns_name::name;`
> that contain nested classes, structs, and enums after the `name` field
> in the declaration (e.g. `using ns_name::name::enum;`).
>
> The language for describing this functionality is ambiguous in the
> C++11 specification as referenced here:
> http://en.cppreference.com/w/cpp/language/namespace#Using-declarations
>
> This patch fixes a bug where we relied on this functionality in clang
> and had build errors in gcc.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 53397fc1da11a71259df1c38526a613676a60301
> src/slave/containerizer/mesos/isolators/cgroups/devices/gpus/nvidia.cpp c2cdc8fde7a85741be6494ea664d3719d1f13a43
>
> Diff: https://reviews.apache.org/r/45622/diff/
>
>
> Testing
> -------
>
> Rebuilt with nvidia gpu support for both clang and gcc.
>
>
> Thanks,
>
> Kevin Klues
>
>