You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2026/01/14 21:21:44 UTC
[PR] Exercise Flink 2.0 test [beam]
Abacn opened a new pull request, #37313:
URL: https://github.com/apache/beam/pull/37313
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR test on Flink 2.0 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3894772903
Assigning reviewers:
R: @shunping for label python.
R: @kennknowles for label java.
R: @liferoad for label build.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR tests on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #37313:
URL: https://github.com/apache/beam/pull/37313#discussion_r2817870439
##########
sdks/python/test-suites/portable/common.gradle:
##########
@@ -508,7 +504,7 @@ def addTestJavaJarCreator(String runner, Task jobServerJarTask) {
}
// TODO(BEAM-11333) Update and test multiple Flink versions.
-addTestJavaJarCreator("FlinkRunner", tasks.getByPath(":runners:flink:${latestFlinkVersion}:job-server:shadowJar"))
+addTestJavaJarCreator("FlinkRunner", tasks.getByPath(":runners:flink:${latestFlink1Version}:job-server:shadowJar"))
Review Comment:
It is intended to test Both Flink 1.20 and 2.0 tasks for testPipelineJarFlinkRunner at the moment (run via https://github.com/apache/beam/blob/master/.github/workflows/beam_PostCommit_PortableJar_Flink.yml). Resolve for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR test on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #37313:
URL: https://github.com/apache/beam/pull/37313#discussion_r2801905366
##########
sdks/python/apache_beam/runners/portability/flink_runner_test.py:
##########
@@ -158,11 +173,12 @@ def _subprocess_command(cls, job_port, expansion_port):
cls._create_conf_dir()
cls.expansion_port = expansion_port
-
+ platform_specific_opts = []
+ if platform.system() == 'Linux':
+ # UseContainerSupport is supported in Linux and turned on by default
+ platform_specific_opts.append('-XX:-UseContainerSupport')
try:
- return [
- 'java',
- '-XX:-UseContainerSupport',
+ return ['java'] + platform_specific_opts + [
Review Comment:
Fix flink_runner_test on MacOS (and persumably windows)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR tests on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #37313:
URL: https://github.com/apache/beam/pull/37313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR tests on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3899493943
R: @damccorm @shunping (for portable runner)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR test on Flink 2.0 [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3894464229
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/37313?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 54.88%. Comparing base ([`22d1c57`](https://app.codecov.io/gh/apache/beam/commit/22d1c576272af62d691ca3124c99b9c563fbbb8c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f29e3d3`](https://app.codecov.io/gh/apache/beam/commit/f29e3d3841cf2a857014274eaf4c72ebb4ee5ca9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #37313 +/- ##
=============================================
+ Coverage 35.88% 54.88% +18.99%
Complexity 1691 1691
=============================================
Files 1063 1063
Lines 166752 166741 -11
Branches 1227 1227
=============================================
+ Hits 59839 91509 +31670
+ Misses 104716 73035 -31681
Partials 2197 2197
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/37313/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/37313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `80.38% <ø> (+40.70%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/37313?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR tests on Flink 2.0 [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3915656231
Thanks - LGTM since no other Gemini suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python and Go PVR test on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3899021609
Many Go VR tests failing with
```
com.esotericsoftware.kryo.KryoException: java.lang.UnsupportedOperationException
Serialization trace:
fieldIndices (org.apache.beam.sdk.schemas.Schema)
schema (org.apache.beam.sdk.values.RowWithStorage)
value (org.apache.beam.sdk.values.KV)
value (org.apache.beam.sdk.values.WindowedValues$ValueInGlobalWindow)
at com.esotericsoftware.kryo.serializers.ReflectField.read(ReflectField.java:146)
at com.esotericsoftware.kryo.serializers.FieldSerializer.read(FieldSerializer.java:130)
at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:796)
at com.esotericsoftware.kryo.serializers.ReflectField.read(ReflectField.java:124)
at com.esotericsoftware.kryo.serializers.FieldSerializer.read(FieldSerializer.java:130)
at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:796)
at com.esotericsoftware.kryo.serializers.ReflectField.read(ReflectField.java:124)
at com.esotericsoftware.kryo.serializers.FieldSerializer.read(FieldSerializer.java:130)
at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:796)
at com.esotericsoftware.kryo.serializers.ReflectField.read(ReflectField.java:124)
at com.esotericsoftware.kryo.serializers.FieldSerializer.read(FieldSerializer.java:130)
at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:877)
at org.apache.flink.api.java.typeutils.runtime.kryo.KryoSerializer.deserialize(KryoSerializer.java:384)
at org.apache.flink.streaming.runtime.streamrecord.StreamElementSerializer.deserialize(StreamElementSerializer.java:206)
at org.apache.flink.streaming.runtime.streamrecord.StreamElementSerializer.deserialize(StreamElementSerializer.java:44)
at org.apache.flink.runtime.plugable.NonReusingDeserializationDelegate.read(NonReusingDeserializationDelegate.java:53)
at org.apache.flink.runtime.io.network.api.serialization.NonSpanningWrapper.readInto(NonSpanningWrapper.java:337)
at org.apache.flink.runtime.io.network.api.serialization.SpillingAdaptiveSpanningRecordDeserializer.readNonSpanningRecord(SpillingAdaptiveSpanningRecordDeserializer.java:130)
at org.apache.flink.runtime.io.network.api.serialization.SpillingAdaptiveSpanningRecordDeserializer.readNextRecord(SpillingAdaptiveSpanningRecordDeserializer.java:105)
at org.apache.flink.runtime.io.network.api.serialization.SpillingAdaptiveSpanningRecordDeserializer.getNextRecord(SpillingAdaptiveSpanningRecordDeserializer.java:95)
at org.apache.flink.streaming.runtime.io.AbstractStreamTaskNetworkInput.emitNext(AbstractStreamTaskNetworkInput.java:152)
at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:65)
at org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:638)
at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:231)
at org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:980)
at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:917)
at org.apache.flink.runtime.taskmanager.Task.runWithSystemExitMonitoring(Task.java:963)
at org.apache.flink.runtime.taskmanager.Task.restoreAndInvoke(Task.java:942)
at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:756)
at org.apache.flink.runtime.taskmanager.Task.run(Task.java:568)
at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.UnsupportedOperationException
at org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.collect.ImmutableMap.put(ImmutableMap.java:781)
at com.esotericsoftware.kryo.serializers.MapSerializer.read(MapSerializer.java:236)
at com.esotericsoftware.kryo.serializers.MapSerializer.read(MapSerializer.java:42)
at com.esotericsoftware.kryo.Kryo.readObject(Kryo.java:796)
at com.esotericsoftware.kryo.serializers.ReflectField.read(ReflectField.java:124)
... 30 more
```
keep using Flink 1.20 for Go tests for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR test on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #37313:
URL: https://github.com/apache/beam/pull/37313#discussion_r2801901590
##########
.github/workflows/beam_PostCommit_Python_Portable_Flink.yml:
##########
@@ -63,8 +63,9 @@ jobs:
job_name: ["beam_PostCommit_Python_Portable_Flink"]
job_phrase: ["Run Python Portable Flink"]
# TODO: Enable PROCESS https://github.com/apache/beam/issues/35702
- # environment_type: ['DOCKER', 'LOOPBACK', 'PROCESS']
- environment_type: ['DOCKER', 'LOOPBACK']
+ # all environment_type: ['DOCKER', 'LOOPBACK', 'PROCESS']
+ # Run modes not covered by PreCommit_Python_PVR_Flink (i.e. other than 'LOOPBACK')
+ environment_type: ['DOCKER']
Review Comment:
LOOPBACK for both Flink 1.20 and Flink 2.0 already have coverage, dedup'd here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Flink 2.0 test [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3751771246
## Summary of Changes
Hello @Abacn, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on preparing the build environment and continuous integration (CI) for Apache Flink 2.0. It refines the Gradle build configuration to dynamically manage Flink versions, specifically enabling the system to recognize Flink 2.0 as the latest version. Additionally, various CI trigger files have been updated, including the introduction of new Flink-related test triggers, to ensure comprehensive testing with the anticipated Flink 2.0 integration.
### Highlights
* **Flink Versioning Logic Update**: The build system's logic for determining the `latestFlinkVersion` has been updated. It now dynamically selects the last version from the `allFlinkVersions` list, removing a previous hardcoded value of '1.20' and a TODO comment related to Flink 2.0 support, indicating readiness for Flink 2.0.
* **CI Trigger File Modifications**: Numerous `.github/trigger_files` have been modified. These changes include incrementing modification/revision counters and removing outdated pull request references, primarily to re-trigger or update existing Flink-related continuous integration tests.
* **New Flink Test Suite Activations**: New empty trigger files have been added for `beam_PostCommit_Java_Tpcds_Flink.json`, `beam_PostCommit_PortableJar_Flink.json`, and `beam_PostCommit_Python_Examples_Flink.json`. This suggests the activation or preparation of new Flink-specific test suites within the CI pipeline.
🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Ignored Files</b></summary>
* **Ignored by pattern:** `.github/workflows/**` (7)
* .github/workflows/beam_PostCommit_Java_Nexmark_Flink.yml
* .github/workflows/beam_PostCommit_Java_PVR_Flink_Streaming.yml
* .github/workflows/beam_PostCommit_Java_Tpcds_Flink.yml
* .github/workflows/beam_PostCommit_Java_ValidatesRunner_Flink.yml
* .github/workflows/beam_PostCommit_XVR_Flink.yml
* .github/workflows/beam_PreCommit_Java_PVR_Flink_Batch.yml
* .github/workflows/beam_PreCommit_Java_PVR_Flink_Docker.yml
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR tests on Flink 2.0 [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #37313:
URL: https://github.com/apache/beam/pull/37313#discussion_r2817827040
##########
sdks/python/test-suites/portable/common.gradle:
##########
@@ -508,7 +504,7 @@ def addTestJavaJarCreator(String runner, Task jobServerJarTask) {
}
// TODO(BEAM-11333) Update and test multiple Flink versions.
-addTestJavaJarCreator("FlinkRunner", tasks.getByPath(":runners:flink:${latestFlinkVersion}:job-server:shadowJar"))
+addTestJavaJarCreator("FlinkRunner", tasks.getByPath(":runners:flink:${latestFlink1Version}:job-server:shadowJar"))
Review Comment:
This change pins `addTestJavaJarCreator` for Flink to `latestFlink1Version` ('1.20'), but the `addTestFlinkUberJar` function (defined on line 510) still uses `latestFlinkVersion`, which will be Flink 2.0.
The `testPipelineJarFlinkRunner` task depends on artifacts from both, which could lead to a version mismatch. Should `addTestFlinkUberJar` also be pinned to `latestFlink1Version` for consistency, or perhaps a new set of uber jar tasks should be created for Flink 2.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR tests on Flink 2.0 [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3915570814
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Flink 2.0 test [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3843231750
PostCommit Java Nexmark Flink: https://github.com/apache/beam/actions/runs/21644527625
PostCommit Java PVR Flink Streaming: https://github.com/apache/beam/actions/runs/21644546969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR tests on Flink 2.0 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3899500510
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR test on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3894616914
Flink 2 Tests passed:
PreCommit Python PVR Flink (runs Flink 2 LOOPBACK):
https://github.com/apache/beam/actions/runs/21971664799
PostCommit Python Portable Flink (runs Flink 2 DOCKER):
https://github.com/apache/beam/actions/runs/21971674796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR test on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #37313:
URL: https://github.com/apache/beam/pull/37313#discussion_r2801903176
##########
sdks/java/extensions/sql/expansion-service/build.gradle:
##########
@@ -56,5 +56,4 @@ shadowJar {
manifest {
attributes(["Multi-Release": true])
}
- outputs.upToDateWhen { false }
Review Comment:
This was a workaround leftover for corrupted remote Gradle cache, could cause elevated compile time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR test on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #37313:
URL: https://github.com/apache/beam/pull/37313#discussion_r2801903176
##########
sdks/java/extensions/sql/expansion-service/build.gradle:
##########
@@ -56,5 +56,4 @@ shadowJar {
manifest {
attributes(["Multi-Release": true])
}
- outputs.upToDateWhen { false }
Review Comment:
This was a workaround leftover for corrupted remote Gradle cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exercise Python PVR test on Flink 2.0 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #37313:
URL: https://github.com/apache/beam/pull/37313#issuecomment-3874005733
Current test failures:
```
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_batch_pardo_fusion_break
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_batch_to_element_pardo
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_flattened_side_input
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_gbk_side_input
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_multimap_multiside_input
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_multimap_side_input
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_multimap_side_input_type_coercion
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_pack_combiners
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_pardo_side_input_dependencies
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_pardo_side_inputs
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_pardo_unfusable_side_inputs
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_pardo_unfusable_side_inputs_with_separation
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_pardo_windowed_side_inputs
FAILED apache_beam/runners/portability/flink_runner_test.py::FlinkRunnerTestOptimized::test_sdf_synthetic_source
```
```
java.lang.IllegalArgumentException
at org.apache.beam.model.pipeline.v1.RunnerApi$Components.getTransformsOrThrow(RunnerApi.java:1038)
at org.apache.beam.runners.flink.FlinkStreamingPortablePipelineTranslator.getSideInputIdToPCollectionViewMap(FlinkStreamingPortablePipelineTranslator.java:991)
at org.apache.beam.runners.flink.FlinkStreamingPortablePipelineTranslator.transformSideInputs(FlinkStreamingPortablePipelineTranslator.java:1033)
at org.apache.beam.runners.flink.FlinkStreamingPortablePipelineTranslator.translateExecutableStage(FlinkStreamingPortablePipelineTranslator.java:755)
at org.apache.beam.runners.flink.FlinkStreamingPortablePipelineTranslator.translate(FlinkStreamingPortablePipelineTranslator.java:280)
at org.apache.beam.runners.flink.FlinkStreamingPortablePipelineTranslator.translate(FlinkStreamingPortablePipelineTranslator.java:127)
at org.apache.beam.runners.flink.FlinkPipelineRunner.runPipelineWithTranslator(FlinkPipelineRunner.java:96)
at org.apache.beam.runners.flink.FlinkPipelineRunner.run(FlinkPipelineRunner.java:86)
at org.apache.beam.runners.jobsubmission.JobInvocation.runPipeline(JobInvocation.java:86)
at org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:131)
at org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:75)
at org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:82)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
```
problems related to side input
https://github.com/apache/beam/actions/runs/21840420138/job/63022922889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org