You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (Created) (JIRA)" <ji...@apache.org> on 2011/10/12 23:49:11 UTC

[jira] [Created] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Add whitelist for hosts used in table/partition locations
---------------------------------------------------------

                 Key: HIVE-2502
                 URL: https://issues.apache.org/jira/browse/HIVE-2502
             Project: Hive
          Issue Type: Improvement
            Reporter: Kevin Wilfong
            Assignee: Kevin Wilfong


Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "Paul Yang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132180#comment-13132180 ] 

Paul Yang commented on HIVE-2502:
---------------------------------

Got failures in a few tests:

alter_view_rename.q
create_or_replace_view.q
create_view.q
recursive_view.q

Seems like the views case isn't properly handled.
                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt, HIVE-2502.3.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "Paul Yang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127844#comment-13127844 ] 

Paul Yang commented on HIVE-2502:
---------------------------------

+1 Will test and commit.
                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt, HIVE-2502.3.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-2502:
--------------------------------

    Attachment: HIVE-2502.2.patch.txt
    
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137318#comment-13137318 ] 

jiraposter@reviews.apache.org commented on HIVE-2502:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/
-----------------------------------------------------------

(Updated 2011-10-27 17:38:58.120670)


Review request for hive and Paul Yang.


Changes
-------

I fixed an issue that was causing altering views to fail.

I ran all the test queries and they succeeded.


Summary
-------

I added a whitelist configuration variable, whose value should be a comma separated list of hosts.  A set of strings is created based on this list and the host name in a location given to a create/alter table/partition command to the HiveMetastore is compared to the values in that set.  If the list is nonempty, the table being altered/created or containing the partition is not external/non-native, and the location has an explicit host, the command is failed if the host is not in that set, otherwise the command continues as normal.


This addresses bug HIVE-2502.
    https://issues.apache.org/jira/browse/HIVE-2502


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1189406 
  trunk/conf/hive-default.xml 1189406 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1189406 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1189406 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1189406 

Diff: https://reviews.apache.org/r/2371/diff


Testing
-------

I used Thrift calls to test the following for each of the 4 commands create/alter table/partition:

Issuing the command with a location with a host that is not in the whitelist fails.
Issuing the command with a location with a host in the whitelist does not fail.


Thanks,

Kevin


                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt, HIVE-2502.3.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-2502:
--------------------------------

    Attachment: HIVE-2502.1.patch.txt
    
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137319#comment-13137319 ] 

jiraposter@reviews.apache.org commented on HIVE-2502:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/#review2881
-----------------------------------------------------------



trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
<https://reviews.apache.org/r/2371/#comment6452>

    This is the only change I made in r4, it now only checks the location if the table is not a view.


- Kevin


On 2011-10-27 17:38:58, Kevin Wilfong wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2371/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-27 17:38:58)
bq.  
bq.  
bq.  Review request for hive and Paul Yang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  I added a whitelist configuration variable, whose value should be a comma separated list of hosts.  A set of strings is created based on this list and the host name in a location given to a create/alter table/partition command to the HiveMetastore is compared to the values in that set.  If the list is nonempty, the table being altered/created or containing the partition is not external/non-native, and the location has an explicit host, the command is failed if the host is not in that set, otherwise the command continues as normal.
bq.  
bq.  
bq.  This addresses bug HIVE-2502.
bq.      https://issues.apache.org/jira/browse/HIVE-2502
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1189406 
bq.    trunk/conf/hive-default.xml 1189406 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1189406 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1189406 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1189406 
bq.  
bq.  Diff: https://reviews.apache.org/r/2371/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  I used Thrift calls to test the following for each of the 4 commands create/alter table/partition:
bq.  
bq.  Issuing the command with a location with a host that is not in the whitelist fails.
bq.  Issuing the command with a location with a host in the whitelist does not fail.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kevin
bq.  
bq.


                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt, HIVE-2502.3.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127151#comment-13127151 ] 

jiraposter@reviews.apache.org commented on HIVE-2502:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/#review2575
-----------------------------------------------------------


Looks good, but can we do host:port combinations instead of just the host?

- Paul


On 2011-10-12 22:48:52, Kevin Wilfong wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2371/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-12 22:48:52)
bq.  
bq.  
bq.  Review request for hive and Paul Yang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  I added a whitelist configuration variable, whose value should be a comma separated list of hosts.  A set of strings is created based on this list and the host name in a location given to a create/alter table/partition command to the HiveMetastore is compared to the values in that set.  If the list is nonempty, the table being altered/created or containing the partition is not external/non-native, and the location has an explicit host, the command is failed if the host is not in that set, otherwise the command continues as normal.
bq.  
bq.  
bq.  This addresses bug HIVE-2502.
bq.      https://issues.apache.org/jira/browse/HIVE-2502
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182505 
bq.    trunk/conf/hive-default.xml 1182505 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1182505 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1182505 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1182505 
bq.  
bq.  Diff: https://reviews.apache.org/r/2371/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  I used Thrift calls to test the following for each of the 4 commands create/alter table/partition:
bq.  
bq.  Issuing the command with a location with a host that is not in the whitelist fails.
bq.  Issuing the command with a location with a host in the whitelist does not fail.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kevin
bq.  
bq.


                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127695#comment-13127695 ] 

jiraposter@reviews.apache.org commented on HIVE-2502:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/
-----------------------------------------------------------

(Updated 2011-10-14 16:56:01.946053)


Review request for hive and Paul Yang.


Changes
-------

All lines are within the 100 char limit.


Summary
-------

I added a whitelist configuration variable, whose value should be a comma separated list of hosts.  A set of strings is created based on this list and the host name in a location given to a create/alter table/partition command to the HiveMetastore is compared to the values in that set.  If the list is nonempty, the table being altered/created or containing the partition is not external/non-native, and the location has an explicit host, the command is failed if the host is not in that set, otherwise the command continues as normal.


This addresses bug HIVE-2502.
    https://issues.apache.org/jira/browse/HIVE-2502


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182505 
  trunk/conf/hive-default.xml 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1182505 

Diff: https://reviews.apache.org/r/2371/diff


Testing
-------

I used Thrift calls to test the following for each of the 4 commands create/alter table/partition:

Issuing the command with a location with a host that is not in the whitelist fails.
Issuing the command with a location with a host in the whitelist does not fail.


Thanks,

Kevin


                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127213#comment-13127213 ] 

jiraposter@reviews.apache.org commented on HIVE-2502:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/
-----------------------------------------------------------

(Updated 2011-10-14 01:27:18.448099)


Review request for hive and Paul Yang.


Changes
-------

Thanks for the feedback Paul.  I changed it to use host:port pairs instead of just hosts.


Summary
-------

I added a whitelist configuration variable, whose value should be a comma separated list of hosts.  A set of strings is created based on this list and the host name in a location given to a create/alter table/partition command to the HiveMetastore is compared to the values in that set.  If the list is nonempty, the table being altered/created or containing the partition is not external/non-native, and the location has an explicit host, the command is failed if the host is not in that set, otherwise the command continues as normal.


This addresses bug HIVE-2502.
    https://issues.apache.org/jira/browse/HIVE-2502


Diffs (updated)
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182505 
  trunk/conf/hive-default.xml 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1182505 

Diff: https://reviews.apache.org/r/2371/diff


Testing
-------

I used Thrift calls to test the following for each of the 4 commands create/alter table/partition:

Issuing the command with a location with a host that is not in the whitelist fails.
Issuing the command with a location with a host in the whitelist does not fail.


Thanks,

Kevin


                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126220#comment-13126220 ] 

jiraposter@reviews.apache.org commented on HIVE-2502:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2371/
-----------------------------------------------------------

Review request for hive and Paul Yang.


Summary
-------

I added a whitelist configuration variable, whose value should be a comma separated list of hosts.  A set of strings is created based on this list and the host name in a location given to a create/alter table/partition command to the HiveMetastore is compared to the values in that set.  If the list is nonempty, the table being altered/created or containing the partition is not external/non-native, and the location has an explicit host, the command is failed if the host is not in that set, otherwise the command continues as normal.


This addresses bug HIVE-2502.
    https://issues.apache.org/jira/browse/HIVE-2502


Diffs
-----

  trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1182505 
  trunk/conf/hive-default.xml 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1182505 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 1182505 

Diff: https://reviews.apache.org/r/2371/diff


Testing
-------

I used Thrift calls to test the following for each of the 4 commands create/alter table/partition:

Issuing the command with a location with a host that is not in the whitelist fails.
Issuing the command with a location with a host in the whitelist does not fail.


Thanks,

Kevin


                
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-2502:
--------------------------------

    Attachment: HIVE-2502.3.patch.txt
    
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt, HIVE-2502.3.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HIVE-2502) Add whitelist for hosts used in table/partition locations

Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Wilfong updated HIVE-2502:
--------------------------------

    Attachment: HIVE-2502.4.patch.txt
    
> Add whitelist for hosts used in table/partition locations
> ---------------------------------------------------------
>
>                 Key: HIVE-2502
>                 URL: https://issues.apache.org/jira/browse/HIVE-2502
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-2502.1.patch.txt, HIVE-2502.2.patch.txt, HIVE-2502.3.patch.txt, HIVE-2502.4.patch.txt
>
>
> Add a whitelist of host names that can be checked before creating/altering a table/partition to verify that the location is acceptable.  The whitelist should be empty by default, and should be configurable.  The check should default to pass if there is no host in the location, or the whitelist is empty.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira