You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by "Oleg Sivokon (Created) (JIRA)" <ji...@apache.org> on 2012/04/04 13:14:23 UTC
[jira] [Created] (FLEX-38) Build script requires sh on Windows
Build script requires sh on Windows
-----------------------------------
Key: FLEX-38
URL: https://issues.apache.org/jira/browse/FLEX-38
Project: Apache Flex
Issue Type: Bug
Environment: Windows
Reporter: Oleg Sivokon
Assignee: Bertrand Delacretaz
There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLEX-38) Build script requires sh on Windows
Posted by "Carol Frampton (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carol Frampton reassigned FLEX-38:
----------------------------------
Assignee: Carol Frampton (was: Bertrand Delacretaz)
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246613#comment-13246613 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
This is really weird... can you try this:
<!-- <untar src="${FLEX_HOME}/in/air/mac/AIR Integration Kit.tbz2" -->
<!-- dest="${FLEX_HOME}" -->
<!-- compression="bzip2"/> -->
<bunzip2 src="${FLEX_HOME}/in/air/mac/AIR Integration Kit.tbz2" dest="${FLEX_HOME}" />
Technically, it should do the same thing...
But there are about 4 symlinks in the archive, which are promised to not function. So probably, this will not achieve the desired result too. But then I don't really know why do Windows users need this.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246180#comment-13246180 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
Nope, they aren't the same, sorry for the noise.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Bertrand Delacretaz
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Justin Mclean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246944#comment-13246944 ]
Justin Mclean commented on FLEX-38:
-----------------------------------
I may be missing something in the details.
But why not do this the same way that build_framework.xml does i.e. ignore the mac framework tbz2 files and just use the windows zip files instead?
Or change the script to only unpack the windows zip on windows something like this:
<target name="prepare" description="Prepares for building framework SWCs" depends="prepare.win,prepare.unix">
<!-- Delete AIR files for 3.x support -->
<delete dir="${FLEX_HOME}/frameworks/libs/air/flex3" quiet="true" />
</target>
<target name="prepare.win">
<!-- Expand the Win AIK on top of the SDK -->
<unzip src="${FLEX_HOME}/in/air/win/AIR Integration Kit.zip" dest="${FLEX_HOME}"/>
<!-- Delete AIK files that we don't put in the SDK -->
<delete file="${FLEX_HOME}/frameworks/libs/air/AIRAliases.js"/>
<delete file="${FLEX_HOME}/frameworks/libs/air/airglobal.abc"/>
<delete file="${FLEX_HOME}/frameworks/libs/air/servicemonitor.swf"/>
<delete file="${FLEX_HOME}/AIR SDK Readme.txt"/>
<delete dir="${FLEX_HOME}/lib/nai"/>
</target>
<target name="prepare.unix" unless="isWindows">
<!-- Expand the Mac AIK on top of the SDK -->
<copy file="${FLEX_HOME}/in/air/mac/AIR Integration Kit.tbz2" todir="${FLEX_HOME}" verbose="true"/>
<echo file="${FLEX_HOME}/air_unzip.sh">#!/bin/sh
tar -xjf "AIR Integration Kit.tbz2"
</echo>
<exec executable="sh" dir="${FLEX_HOME}">
<arg line="${FLEX_HOME}/air_unzip.sh"/>
</exec>
<delete file="${FLEX_HOME}/air_unzip.sh"/>
<delete file="${FLEX_HOME}/AIR Integration Kit.tbz2"/>
</target>
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246638#comment-13246638 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
Nah, sorry, that won't work, just realized it only extracts the tarball, the untar task is deficient.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (FLEX-38) Build script requires sh on
Windows
Posted by "Carol Frampton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269665#comment-13269665 ]
Carol Frampton edited comment on FLEX-38 at 5/7/12 2:47 PM:
------------------------------------------------------------
All the code to unzip the AIR Integration Kit has been removed so this is now a non-issue.
I don't know if this was the only bit of code that required a shell on Windows. Can someone with a Windows system verify? If so, I can update the README to remove the prerequisite of a unix shell on Windows.
was (Author: cframpton):
All the code to unzip the AIR Integration Kit has been removed so this is no a non-issue.
I don't know if this was the only bit of code that required a shell on Windows. Can someone with a Windows system verify? If so, I can update the README to remove the prerequisite of a unix shell on Windows.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Sivokon updated FLEX-38:
-----------------------------
Attachment: build.patch
There were few redundant lines left, removed them too. It is strange, however that the next ZIP file seems to contain all the same files that BZ2 does. Is that by design? (I didn't run diff on both versions, but at the first sight they seem the same to me).
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Bertrand Delacretaz
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Justin Mclean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246264#comment-13246264 ]
Justin Mclean commented on FLEX-38:
-----------------------------------
Patch looks good to me. Any other committers want to double check on windows?
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Bertrand Delacretaz
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246677#comment-13246677 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
Funny, it could be actually possible to extract it on Windows using this: http://gnuwin32.sourceforge.net/packages/libarchive.htm it provides BSD license and is possible to download and run from Ant.
On *nix the below seems to do exactly the same what the old code used to do, w/o opening yet another shell:
<target name="prepare" depends="airsdk-download" description="Prepares for building framework SWCs">
<exec executable="tar">
<arg value="-xjf"/>
<arg value="${FLEX_HOME}/in/air/mac/AIR Integration Kit.tbz2"/>
</exec>
<!-- Expand the Win AIK on top of the SDK -->
<unzip src="${FLEX_HOME}/in/air/win/AIR Integration Kit.zip" dest="${FLEX_HOME}"/>
. . .
But then again, is this really needed on Windows?
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Carol Frampton (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246567#comment-13246567 ]
Carol Frampton commented on FLEX-38:
------------------------------------
So I was going to include your change but something isn't right. I tend to to svn status a lot and I noticed lots of unversioned files at the root which I didn't recognize.
If I untar the file with the command line the directory looks like
AIR SDK Readme.txt
AIR SDK license.pdf
bin/
frameworks/
include/
lib/
runtimes/
samples/
templates/
and if I untar it with the ant command it looks like
1.0/
AIR SDK Readme.txt
AIR SDK license.pdf
Android/
AndroidLicensingLib/
ApplicationUpdater/
Licensing/
Versions/
air/
air-captive/
bin/
frameworks/
include/
lib/
mac/
projects/
runtimes/
samples/
src/
templates/
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Carol Frampton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269665#comment-13269665 ]
Carol Frampton commented on FLEX-38:
------------------------------------
All the code to unzip the AIR Integration Kit has been removed so this is no a non-issue.
I don't know if this was the only bit of code that required a shell on Windows. Can someone with a Windows system verify? If so, I can update the README to remove the prerequisite of a unix shell on Windows.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247153#comment-13247153 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
I'd still remove the call to sh.
It's not uncommon (on the contrary, it's very common) to alias sh to run it with some options other than of your "normal" user, besides, it's really redundant to call sh only to call tar afterwards. You don't need to copy the archive too because tar will untar into the current directory from whatever directory the file is in.
I would really need to check if isWindows will be true in Cygwin.
<property environment="env"/>
<property name="is${env.OSTYPE}" value="true"/>
<target name="cygCheck" if="iscygwin">
<echo message="Running under Cygwin"/>
</target>
This would be a better way to find out what OS the script runs in. It's possibly better to treat cygwin users as if they were on *nix, if possible... well, I guess.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247130#comment-13247130 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
This is what I'm trying to ask:
- the contents of two archives is not the same.
- but they seem to do the same thing for different OSs.
- there is almost no way to extract bzip archive to Windows correctly (it has 4 symlinks inside, symlinks are supported only since Windows Vista). On XP it would probably try to copy the symlinked stuff (duplicating it), but if it is recursive, it won't work.
Now, what I was thinking - what if someone builds on Windows using Cygwin or gnuwin32 utilities and they want to build "as if it was on *nix" - will they need this part of the SDK? Which is to say, if the script discovers it runs inside Cygwin, it extracts the archive, but if it's CMD, then it skips it?
By the way, the archive is _huge_ so if Windows users don't need it entirely, by removing it, you would remove something like 1/5 of the entire SDK download, which may be a very welcomed change :)
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268677#comment-13268677 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
This is sort of a reminder:
+<<<<<<< .mine
+ <exec executable="tar">
+ <arg value="-xjf"/>
+ <arg value="${FLEX_HOME}/in/air/mac/AIR Integration Kit.tbz2"/>
+ </exec>
+=======
<!-- Expand the Mac AIK on top of the SDK -->
+ <!-- Note: any symlinks in this package will be lost since ant tar doesn't support them. -->
<copy file="${FLEX_HOME}/in/air/mac/AIR Integration Kit.tbz2" todir="${FLEX_HOME}" verbose="true"/>
<echo file="${FLEX_HOME}/air_unzip.sh">#!/bin/sh
tar -xjf "AIR Integration Kit.tbz2"
@@ -232,23 +276,41 @@
</exec>
<delete file="${FLEX_HOME}/air_unzip.sh"/>
<delete file="${FLEX_HOME}/AIR Integration Kit.tbz2"/>
+>>>>>>> .r1334140
Please don't call sh like that - it doesn't do what you think it does on Linux. Also, you don't need to copy the archive, tar will untar into current directory, not the archive directory (this will win you some time, especially if you are doing this under Cygwin because the archive is huge and copying it takes time).
Besides, the comment about symlinks is wrong - they would've been lost if you used Ant's <unbzip> task, but they aren't lost with the present code.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Sivokon updated FLEX-38:
-----------------------------
Attachment: build.patch
Patch (seems to work)
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Bertrand Delacretaz
> Labels: Build,Ant
> Attachments: build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Carol Frampton (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246307#comment-13246307 ]
Carol Frampton commented on FLEX-38:
------------------------------------
At the moment this isn't a bug. The Flex build on Windows has always assumed you are using Cygwin or another shell. I would be willing to try to eliminate this requirement if we can figure out why its there and "what all" needs to change to eliminate this requirement.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Justin Mclean (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247132#comment-13247132 ]
Justin Mclean commented on FLEX-38:
-----------------------------------
I'd guess (but not 100% sure) that it's only required to compile air application for mac and as such could be an optional download on windows. Right now there probably no harm caused by not including it when compiling on windows. Can anyone confirm this?
The change I suggested above doesn't care what shell you have only what OS you running on. Look at the task that sets isWindows at the top of the build script.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Carol Frampton (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246340#comment-13246340 ]
Carol Frampton commented on FLEX-38:
------------------------------------
The asc-tests target is crud since the asc tests aren't being donated.
There were some <exec> tags which I removed from the top-level build.xml. You need to wait for mustella which is a beast. I have no idea what it may want.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246330#comment-13246330 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
What, besides <exec> can be OS-specific? Beside this place, I only found one place where it requires python... sort of inventive for the Ant script :) it's in the topmost build file in asc-tests target. But the python script it wants to run doesn't seem to be there, so I can't tell what was it trying to do.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Carol Frampton (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246380#comment-13246380 ]
Carol Frampton commented on FLEX-38:
------------------------------------
Ok, I see why rather than using <untar>s, <exec>s of the shell command, untar, where used.
Ant's untar task can't handle symlinks which as far as I can tell has been a long standing issue.
Now I don't know whether the build engineer who wrote most of these scripts figured out whether each tar file had symlinks in it or just always used the shell command to be safe.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLEX-38) Build script requires sh on Windows
Posted by "Oleg Sivokon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLEX-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246395#comment-13246395 ]
Oleg Sivokon commented on FLEX-38:
----------------------------------
1. How would symlinks be handled on Windows? (I'm not even sure Windows users need that part of the SDK at all - it seem to be the ADL + supporting libraries for launching it on *nix).
2. Doing it the way it was done is a bad idea too, because the permissions given to the user of the terminal / shell running the build may differ from those given to the sh shell called in this way (it actually was for me), so that Ant can't later delete the files extracted in this way.
> Build script requires sh on Windows
> -----------------------------------
>
> Key: FLEX-38
> URL: https://issues.apache.org/jira/browse/FLEX-38
> Project: Apache Flex
> Issue Type: Bug
> Environment: Windows
> Reporter: Oleg Sivokon
> Assignee: Carol Frampton
> Labels: Build,Ant
> Attachments: build.patch, build.patch
>
>
> There is a call to sh with automatically generated shell script that was used to untar the AIR archive. On Windows it wouldn't work and on Linux it would unpack with the permissions given to the user of the terminal, rather then the permissions given to Ant user (files created would be protected for Ant script later).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira