You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2023/01/28 08:07:52 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #16157: [Bug](exec) enable warning on ignoring function return value for vctx
BiteTheDDDDt opened a new pull request, #16157:
URL: https://github.com/apache/doris/pull/16157
# Proposed changes
enable warning on ignoring function return value for vctx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #16157: [Bug](exec) enable warning on ignoring function return value for vctx
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #16157:
URL: https://github.com/apache/doris/pull/16157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16157: [Bug](exec) enable warning on ignoring function return value for vctx
Posted by github-actions.
github-actions[bot] commented on code in PR #16157:
URL: https://github.com/apache/doris/pull/16157#discussion_r1089725536
##########
be/test/vec/exprs/vexpr_test.cpp:
##########
@@ -83,8 +86,11 @@ TEST(TEST_VEXPR, ABSTEST2) {
DescriptorTbl desc_tbl;
Review Comment:
warning: calling a private constructor of class 'doris::DescriptorTbl' [clang-diagnostic-error]
```cpp
DescriptorTbl desc_tbl;
^
```
**be/src/runtime/descriptors.h:426:** declared private here
```cpp
DescriptorTbl() = default;
^
```
##########
be/test/vec/exprs/vexpr_test.cpp:
##########
@@ -83,8 +86,11 @@
DescriptorTbl desc_tbl;
desc_tbl._slot_desc_map[0] = tuple_desc->slots()[0];
Review Comment:
warning: '_slot_desc_map' is a private member of 'doris::DescriptorTbl' [clang-diagnostic-error]
```cpp
desc_tbl._slot_desc_map[0] = tuple_desc->slots()[0];
^
```
**be/src/runtime/descriptors.h:423:** declared private here
```cpp
SlotDescriptorMap _slot_desc_map;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #16157: [Bug](exec) enable warning on ignoring function return value for vctx
Posted by github-actions.
github-actions[bot] commented on PR #16157:
URL: https://github.com/apache/doris/pull/16157#issuecomment-1407328157
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #16157: [Bug](exec) enable warning on ignoring function return value for vctx
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #16157:
URL: https://github.com/apache/doris/pull/16157#issuecomment-1407363069
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.56 seconds
load time: 543 seconds
storage size: 17122534818 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230128095756_clickbench_pr_85521.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org