[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #742: [#133] feat(netty): Add Encoder and Decoder.

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on code in PR #742:
URL: https://github.com/apache/incubator-uniffle/pull/742#discussion_r1145579974


##########
common/src/main/java/org/apache/uniffle/common/ShuffleBlockInfo.java:
##########
@@ -27,14 +31,21 @@ public class ShuffleBlockInfo {
   private int shuffleId;
   private long crc;
   private long taskAttemptId;
-  private byte[] data;
+  private ByteBuf data;

Review Comment:
   This is OK for me, let's make netty first



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org