You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/15 09:33:08 UTC
[GitHub] [arrow] kou opened a new pull request #10533: ARROW-11782: [GLib][Dataset] Remove bindings for internal classes
kou opened a new pull request #10533:
URL: https://github.com/apache/arrow/pull/10533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10533: ARROW-11782: [GLib][Dataset] Remove bindings for internal classes
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10533:
URL: https://github.com/apache/arrow/pull/10533#discussion_r651619914
##########
File path: cpp/src/arrow/dataset/discovery.h
##########
@@ -237,16 +237,22 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public DatasetFactory {
std::shared_ptr<FileFormat> format,
FileSystemFactoryOptions options);
+ /// \brief Build a FileSystemDatasetFactory from an explicit list of
+ /// filesystem information.
+ ///
+ /// \param[in] files passed to FileSystemDataset
+ /// \param[in] format passed to FileSystemDataset
+ /// \param[in] options see FileSystemFactoryOptions for more information.
+ static Result<std::shared_ptr<DatasetFactory>> Make(
+ std::shared_ptr<fs::FileSystem> filesystem, const std::vector<fs::FileInfo>& files,
+ std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
+
Result<std::vector<std::shared_ptr<Schema>>> InspectSchemas(
InspectOptions options) override;
Result<std::shared_ptr<Dataset>> Finish(FinishOptions options) override;
protected:
- static Result<std::shared_ptr<DatasetFactory>> Make(
- std::shared_ptr<fs::FileSystem> filesystem, const std::vector<fs::FileInfo>& files,
- std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
-
Review comment:
@bkietz Can we export this factory method? I want to use this in Apache Arrow Dataset GLib.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10533: ARROW-11782: [GLib][Dataset] Remove bindings for internal classes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10533:
URL: https://github.com/apache/arrow/pull/10533#issuecomment-861345972
https://issues.apache.org/jira/browse/ARROW-11782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10533: ARROW-11782: [GLib][Ruby][Dataset] Remove bindings for internal classes
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10533:
URL: https://github.com/apache/arrow/pull/10533#issuecomment-862040858
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10533: ARROW-11782: [GLib][Dataset] Remove bindings for internal classes
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10533:
URL: https://github.com/apache/arrow/pull/10533#discussion_r652249485
##########
File path: cpp/src/arrow/dataset/discovery.h
##########
@@ -237,16 +237,22 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public DatasetFactory {
std::shared_ptr<FileFormat> format,
FileSystemFactoryOptions options);
+ /// \brief Build a FileSystemDatasetFactory from an explicit list of
+ /// filesystem information.
+ ///
+ /// \param[in] files passed to FileSystemDataset
+ /// \param[in] format passed to FileSystemDataset
+ /// \param[in] options see FileSystemFactoryOptions for more information.
+ static Result<std::shared_ptr<DatasetFactory>> Make(
+ std::shared_ptr<fs::FileSystem> filesystem, const std::vector<fs::FileInfo>& files,
+ std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
+
Result<std::vector<std::shared_ptr<Schema>>> InspectSchemas(
InspectOptions options) override;
Result<std::shared_ptr<Dataset>> Finish(FinishOptions options) override;
protected:
- static Result<std::shared_ptr<DatasetFactory>> Make(
- std::shared_ptr<fs::FileSystem> filesystem, const std::vector<fs::FileInfo>& files,
- std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
-
Review comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on a change in pull request #10533: ARROW-11782: [GLib][Dataset] Remove bindings for internal classes
Posted by GitBox <gi...@apache.org>.
bkietz commented on a change in pull request #10533:
URL: https://github.com/apache/arrow/pull/10533#discussion_r651910568
##########
File path: cpp/src/arrow/dataset/discovery.h
##########
@@ -237,16 +237,22 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public DatasetFactory {
std::shared_ptr<FileFormat> format,
FileSystemFactoryOptions options);
+ /// \brief Build a FileSystemDatasetFactory from an explicit list of
+ /// filesystem information.
+ ///
+ /// \param[in] files passed to FileSystemDataset
+ /// \param[in] format passed to FileSystemDataset
+ /// \param[in] options see FileSystemFactoryOptions for more information.
+ static Result<std::shared_ptr<DatasetFactory>> Make(
+ std::shared_ptr<fs::FileSystem> filesystem, const std::vector<fs::FileInfo>& files,
+ std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
+
Result<std::vector<std::shared_ptr<Schema>>> InspectSchemas(
InspectOptions options) override;
Result<std::shared_ptr<Dataset>> Finish(FinishOptions options) override;
protected:
- static Result<std::shared_ptr<DatasetFactory>> Make(
- std::shared_ptr<fs::FileSystem> filesystem, const std::vector<fs::FileInfo>& files,
- std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
-
Review comment:
If it's convenient for you I think it's fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10533: ARROW-11782: [GLib][Ruby][Dataset] Remove bindings for internal classes
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10533:
URL: https://github.com/apache/arrow/pull/10533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10533: ARROW-11782: [GLib][Dataset] Remove bindings for internal classes
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10533:
URL: https://github.com/apache/arrow/pull/10533#discussion_r651619914
##########
File path: cpp/src/arrow/dataset/discovery.h
##########
@@ -237,16 +237,22 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public DatasetFactory {
std::shared_ptr<FileFormat> format,
FileSystemFactoryOptions options);
+ /// \brief Build a FileSystemDatasetFactory from an explicit list of
+ /// filesystem information.
+ ///
+ /// \param[in] files passed to FileSystemDataset
+ /// \param[in] format passed to FileSystemDataset
+ /// \param[in] options see FileSystemFactoryOptions for more information.
+ static Result<std::shared_ptr<DatasetFactory>> Make(
+ std::shared_ptr<fs::FileSystem> filesystem, const std::vector<fs::FileInfo>& files,
+ std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
+
Result<std::vector<std::shared_ptr<Schema>>> InspectSchemas(
InspectOptions options) override;
Result<std::shared_ptr<Dataset>> Finish(FinishOptions options) override;
protected:
- static Result<std::shared_ptr<DatasetFactory>> Make(
- std::shared_ptr<fs::FileSystem> filesystem, const std::vector<fs::FileInfo>& files,
- std::shared_ptr<FileFormat> format, FileSystemFactoryOptions options);
-
Review comment:
@bkietz Can we export this constructor? I want to use this in Apache Arrow Dataset GLib.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org