You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "eduosi (via GitHub)" <gi...@apache.org> on 2024/10/30 07:01:09 UTC
[PR] fix: ConsulMetadataReport overrides the registerServiceAppMapping method and returns true [dubbo-spi-extensions]
eduosi opened a new pull request, #552:
URL: https://github.com/apache/dubbo-spi-extensions/pull/552
## What is the purpose of the change
Because ConsulMetadataReport not rewrite the method of interface MetadataReport registerServiceAppMapping, it always returns false. Leading to MetadataServiceNameMapping methods map URL (URL) always appear: Failed to publish service name mapping to metadata center by cas operation. [apache/dubbo#14764](https://github.com/apache/dubbo/issues/14764)
## Brief changelog
ConsulMetadataReport overrides the registerServiceAppMapping method and returns true.
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit
in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
exist. If the new feature or significant change is committed, please remember to add sample
in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure
unit-test and integration-test pass.
- [ ] If this contribution is large, please follow
the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix: ConsulMetadataReport overrides the registerServiceAppMapping method and returns true [dubbo-spi-extensions]
Posted by "eduosi (via GitHub)" <gi...@apache.org>.
eduosi closed pull request #552: fix: ConsulMetadataReport overrides the registerServiceAppMapping method and returns true
URL: https://github.com/apache/dubbo-spi-extensions/pull/552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org