You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2011/06/23 18:11:48 UTC

[jira] [Created] (CASSANDRA-2817) Expose number of threads blocked on submitting a memtable for flush

Expose number of threads blocked on submitting a memtable for flush
-------------------------------------------------------------------

                 Key: CASSANDRA-2817
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2817
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.7.0
            Reporter: Sylvain Lebresne
            Assignee: Sylvain Lebresne
            Priority: Minor
             Fix For: 0.7.7


Writes can be blocked by a thread trying to submit a memtable while the flush queue is full. While this is the expected behavior (the goal being to prevent OOMing), it is worth exposing when that happens so that people can monitor it and modify settings accordingly if that happens too often.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2817) Expose number of threads blocked on submitting a memtable for flush

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-2817:
----------------------------------------

    Attachment: 0001-Expose-threads-blocked-on-submission-to-executor-v2.patch

Attaching v2 with support in StatusLogger and tpstats.

> Expose number of threads blocked on submitting a memtable for flush
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-2817
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2817
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.7
>
>         Attachments: 0001-Expose-threads-blocked-on-submission-to-executor-v2.patch, 0001-Expose-threads-blocked-on-submission-to-executor.patch
>
>
> Writes can be blocked by a thread trying to submit a memtable while the flush queue is full. While this is the expected behavior (the goal being to prevent OOMing), it is worth exposing when that happens so that people can monitor it and modify settings accordingly if that happens too often.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-2817) Expose number of threads blocked on submitting a memtable for flush

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne updated CASSANDRA-2817:
----------------------------------------

    Attachment: 0001-Expose-threads-blocked-on-submission-to-executor.patch

> Expose number of threads blocked on submitting a memtable for flush
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-2817
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2817
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.7
>
>         Attachments: 0001-Expose-threads-blocked-on-submission-to-executor.patch
>
>
> Writes can be blocked by a thread trying to submit a memtable while the flush queue is full. While this is the expected behavior (the goal being to prevent OOMing), it is worth exposing when that happens so that people can monitor it and modify settings accordingly if that happens too often.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2817) Expose number of threads blocked on submitting a memtable for flush

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053947#comment-13053947 ] 

Jonathan Ellis commented on CASSANDRA-2817:
-------------------------------------------

Very clever solution, I like it.

Can you add "currently blocked" to statuslogger and nodetool tpstats?

> Expose number of threads blocked on submitting a memtable for flush
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-2817
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2817
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.7
>
>         Attachments: 0001-Expose-threads-blocked-on-submission-to-executor.patch
>
>
> Writes can be blocked by a thread trying to submit a memtable while the flush queue is full. While this is the expected behavior (the goal being to prevent OOMing), it is worth exposing when that happens so that people can monitor it and modify settings accordingly if that happens too often.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2817) Expose number of threads blocked on submitting a memtable for flush

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053990#comment-13053990 ] 

Hudson commented on CASSANDRA-2817:
-----------------------------------

Integrated in Cassandra-0.7 #510 (See [https://builds.apache.org/job/Cassandra-0.7/510/])
    Expose number of threads blocked on submitting a memtable for flush
patch by slebresne; reviewed by jbellis for CASSANDRA-2817

slebresne : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1138996
Files : 
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutor.java
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutorMBean.java
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/utils/StatusLogger.java
* /cassandra/branches/cassandra-0.7/CHANGES.txt
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/concurrent/JMXEnabledThreadPoolExecutor.java
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/tools/NodeProbe.java
* /cassandra/branches/cassandra-0.7/src/java/org/apache/cassandra/tools/NodeCmd.java


> Expose number of threads blocked on submitting a memtable for flush
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-2817
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2817
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.7, 0.8.2
>
>         Attachments: 0001-Expose-threads-blocked-on-submission-to-executor-v2.patch, 0001-Expose-threads-blocked-on-submission-to-executor.patch
>
>
> Writes can be blocked by a thread trying to submit a memtable while the flush queue is full. While this is the expected behavior (the goal being to prevent OOMing), it is worth exposing when that happens so that people can monitor it and modify settings accordingly if that happens too often.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2817) Expose number of threads blocked on submitting a memtable for flush

Posted by "Ryan King (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053946#comment-13053946 ] 

Ryan King commented on CASSANDRA-2817:
--------------------------------------

+1

> Expose number of threads blocked on submitting a memtable for flush
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-2817
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2817
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.7
>
>         Attachments: 0001-Expose-threads-blocked-on-submission-to-executor.patch
>
>
> Writes can be blocked by a thread trying to submit a memtable while the flush queue is full. While this is the expected behavior (the goal being to prevent OOMing), it is worth exposing when that happens so that people can monitor it and modify settings accordingly if that happens too often.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CASSANDRA-2817) Expose number of threads blocked on submitting a memtable for flush

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sylvain Lebresne resolved CASSANDRA-2817.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8.2
         Reviewer: jbellis

Committed, thanks

> Expose number of threads blocked on submitting a memtable for flush
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-2817
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2817
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.7, 0.8.2
>
>         Attachments: 0001-Expose-threads-blocked-on-submission-to-executor-v2.patch, 0001-Expose-threads-blocked-on-submission-to-executor.patch
>
>
> Writes can be blocked by a thread trying to submit a memtable while the flush queue is full. While this is the expected behavior (the goal being to prevent OOMing), it is worth exposing when that happens so that people can monitor it and modify settings accordingly if that happens too often.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-2817) Expose number of threads blocked on submitting a memtable for flush

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053970#comment-13053970 ] 

Jonathan Ellis commented on CASSANDRA-2817:
-------------------------------------------

+1

> Expose number of threads blocked on submitting a memtable for flush
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-2817
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2817
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>            Priority: Minor
>             Fix For: 0.7.7
>
>         Attachments: 0001-Expose-threads-blocked-on-submission-to-executor-v2.patch, 0001-Expose-threads-blocked-on-submission-to-executor.patch
>
>
> Writes can be blocked by a thread trying to submit a memtable while the flush queue is full. While this is the expected behavior (the goal being to prevent OOMing), it is worth exposing when that happens so that people can monitor it and modify settings accordingly if that happens too often.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira