You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ma...@apache.org on 2013/12/28 04:10:21 UTC
[1/2] git commit: Removed unused OtherFailure TaskEndReason.
Updated Branches:
refs/heads/master b579b8327 -> ad3dfd153
Removed unused OtherFailure TaskEndReason.
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/e17d7518
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/e17d7518
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/e17d7518
Branch: refs/heads/master
Commit: e17d7518ab10c218c9576db5754c7fa4cb92688a
Parents: 19672dc
Author: Kay Ousterhout <ka...@gmail.com>
Authored: Fri Dec 27 15:51:27 2013 -0800
Committer: Kay Ousterhout <ka...@gmail.com>
Committed: Fri Dec 27 15:51:27 2013 -0800
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/TaskEndReason.scala | 2 --
core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala | 4 ----
2 files changed, 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/e17d7518/core/src/main/scala/org/apache/spark/TaskEndReason.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/TaskEndReason.scala b/core/src/main/scala/org/apache/spark/TaskEndReason.scala
index c1e5e04..faf6dcd 100644
--- a/core/src/main/scala/org/apache/spark/TaskEndReason.scala
+++ b/core/src/main/scala/org/apache/spark/TaskEndReason.scala
@@ -53,5 +53,3 @@ private[spark] case class ExceptionFailure(
private[spark] case object TaskResultLost extends TaskEndReason
private[spark] case object TaskKilled extends TaskEndReason
-
-private[spark] case class OtherFailure(message: String) extends TaskEndReason
http://git-wip-us.apache.org/repos/asf/incubator-spark/blob/e17d7518/core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala b/core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala
index 6092783..be5c95e 100644
--- a/core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala
+++ b/core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala
@@ -328,10 +328,6 @@ class JobLogger(val user: String, val logDirName: String)
task.stageId + " SHUFFLE_ID=" + shuffleId + " MAP_ID=" +
mapId + " REDUCE_ID=" + reduceId
stageLogInfo(task.stageId, taskStatus)
- case OtherFailure(message) =>
- taskStatus += " STATUS=FAILURE TID=" + taskInfo.taskId +
- " STAGE_ID=" + task.stageId + " INFO=" + message
- stageLogInfo(task.stageId, taskStatus)
case _ =>
}
}
[2/2] git commit: Merge pull request #307 from
kayousterhout/other_failure
Posted by ma...@apache.org.
Merge pull request #307 from kayousterhout/other_failure
Removed unused OtherFailure TaskEndReason.
The OtherFailure TaskEndReason was added by @mateiz 3 years ago in this commit: https://github.com/apache/incubator-spark/commit/24a1e7f8380bfd8d4fbdda688482a451bd6ea215
Unless I am missing something, it doesn't seem to have been used then, and is not used now, so seems safe for deletion.
Project: http://git-wip-us.apache.org/repos/asf/incubator-spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-spark/commit/ad3dfd15
Tree: http://git-wip-us.apache.org/repos/asf/incubator-spark/tree/ad3dfd15
Diff: http://git-wip-us.apache.org/repos/asf/incubator-spark/diff/ad3dfd15
Branch: refs/heads/master
Commit: ad3dfd153196497fefe6c1925e0a495a4373f1c5
Parents: b579b83 e17d751
Author: Matei Zaharia <ma...@databricks.com>
Authored: Fri Dec 27 22:10:14 2013 -0500
Committer: Matei Zaharia <ma...@databricks.com>
Committed: Fri Dec 27 22:10:14 2013 -0500
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/TaskEndReason.scala | 2 --
core/src/main/scala/org/apache/spark/scheduler/JobLogger.scala | 4 ----
2 files changed, 6 deletions(-)
----------------------------------------------------------------------