[jira] [Comment Edited] (WICKET-5683) PreviousButton isEnabled() should bo logical conjunction of getWizardModel().isPreviousAvailable() and super.isEnabled()

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112191#comment-14112191 ] 

Martin Grigorov edited comment on WICKET-5683 at 8/27/14 12:17 PM:
-------------------------------------------------------------------

The same is valid for LastButton, no ?
NextButton already have this check.
What about FinishButton ?


was (Author: mgrigorov):
The same is valid for LastButton, no ?
NextButton already have this check.

> PreviousButton isEnabled() should bo logical conjunction of getWizardModel().isPreviousAvailable() and super.isEnabled()
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-5683
>                 URL: https://issues.apache.org/jira/browse/WICKET-5683
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>            Reporter: Mikael Björertz
>            Assignee: Andrea Del Bene
>              Labels: navigation, wizard
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The implementation of isEnabled in PreviousButton breaks the implicit contract of setEnabled(false) -> isEnabled() returning false.
> Implementation should be 
> return super.isEnabled() && getWizardModel().isPreviousAvailable();



--
This message was sent by Atlassian JIRA
(v6.2#6252)