You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Raghav Gautam <ra...@apache.org> on 2014/12/02 02:03:16 UTC
Re: Review Request 28424: Release readiness for falcon-regression aka
merlin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28424/
-----------------------------------------------------------
(Updated Dec. 1, 2014, 5:03 p.m.)
Review request for Falcon.
Bugs: falcon-900
https://issues.apache.org/jira/browse/falcon-900
Repository: falcon-git
Description
-------
This patch fixes checkstyle and findbugs issue.
Diffs (updated)
-----
falcon-regression/checkstyle/pom.xml 89f785f
falcon-regression/checkstyle/src/main/resources/falcon/checkstyle-java-header.txt 5d5f1e3
falcon-regression/checkstyle/src/main/resources/falcon/checkstyle-noframes.xsl 4d10dd7
falcon-regression/checkstyle/src/main/resources/falcon/checkstyle.xml 37e01b4
falcon-regression/checkstyle/src/main/resources/falcon/findbugs-exclude.xml 4de6b23
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java e4ab0ee
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java a42416a
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgesResult.java 357e340
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Vertex.java 5bbe72f
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/HadoopFileEditor.java 32f50dc
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/GraphAssert.java b87dd4e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java ede5cee
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java b061700
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/XmlUtil.java f0ea328
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 4359b16
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedClusterUpdateTest.java c2ae1f9
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java 650d4c3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java b7afad4
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java 8395476
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java b1a2393
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 2a4a9c1
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java af1a751
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java 63f98f2
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java cfe1119
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java b585665
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java 4ffc64f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java 1d3f88d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java bde4e65
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java 76345e0
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java 1cf44b7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 902ec23
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java 279dc56
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java 4a0c10e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 51fcb8d
falcon-regression/pom.xml c204d14
Diff: https://reviews.apache.org/r/28424/diff/
Testing
-------
I have done some testing as I made changes but complete ground was not covered.
Thanks,
Raghav Gautam
Re: Review Request 28424: Release readiness for falcon-regression aka
merlin
Posted by Raghav Gautam <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28424/
-----------------------------------------------------------
(Updated Dec. 2, 2014, 10:36 a.m.)
Review request for Falcon.
Bugs: falcon-928
https://issues.apache.org/jira/browse/falcon-928
Repository: falcon-git
Description
-------
This patch fixes checkstyle and findbugs issue.
Diffs
-----
falcon-regression/checkstyle/pom.xml 89f785f
falcon-regression/checkstyle/src/main/resources/falcon/checkstyle-java-header.txt 5d5f1e3
falcon-regression/checkstyle/src/main/resources/falcon/checkstyle-noframes.xsl 4d10dd7
falcon-regression/checkstyle/src/main/resources/falcon/checkstyle.xml 37e01b4
falcon-regression/checkstyle/src/main/resources/falcon/findbugs-exclude.xml 4de6b23
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java e4ab0ee
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java a42416a
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgesResult.java 357e340
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Vertex.java 5bbe72f
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/HadoopFileEditor.java 32f50dc
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/GraphAssert.java b87dd4e
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java ede5cee
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java b061700
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/XmlUtil.java f0ea328
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 4359b16
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedClusterUpdateTest.java c2ae1f9
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java 650d4c3
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java b7afad4
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java 8395476
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java b1a2393
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 2a4a9c1
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java af1a751
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java 63f98f2
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java cfe1119
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java b585665
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java 4ffc64f
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java 1d3f88d
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java bde4e65
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java 76345e0
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java 1cf44b7
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 902ec23
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java 279dc56
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java 4a0c10e
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 51fcb8d
falcon-regression/pom.xml c204d14
Diff: https://reviews.apache.org/r/28424/diff/
Testing
-------
I have done some testing as I made changes but complete ground was not covered.
Thanks,
Raghav Gautam
Re: Review Request 28424: Release readiness for falcon-regression aka
merlin
Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28424/#review63527
-----------------------------------------------------------
Ship it!
Patch is fine, but I thinks it should be committed as sub-task
- Ruslan Ostafiychuk
On Dec. 2, 2014, 1:03 a.m., Raghav Gautam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28424/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 1:03 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-900
> https://issues.apache.org/jira/browse/falcon-900
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> This patch fixes checkstyle and findbugs issue.
>
>
> Diffs
> -----
>
> falcon-regression/checkstyle/pom.xml 89f785f
> falcon-regression/checkstyle/src/main/resources/falcon/checkstyle-java-header.txt 5d5f1e3
> falcon-regression/checkstyle/src/main/resources/falcon/checkstyle-noframes.xsl 4d10dd7
> falcon-regression/checkstyle/src/main/resources/falcon/checkstyle.xml 37e01b4
> falcon-regression/checkstyle/src/main/resources/falcon/findbugs-exclude.xml 4de6b23
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java e4ab0ee
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Edge.java a42416a
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/EdgesResult.java 357e340
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/response/lineage/Vertex.java 5bbe72f
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/HadoopFileEditor.java 32f50dc
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/GraphAssert.java b87dd4e
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java ede5cee
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java b061700
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/XmlUtil.java f0ea328
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ExternalFSTest.java 4359b16
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedClusterUpdateTest.java c2ae1f9
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java 650d4c3
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedReplicationTest.java b7afad4
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/InstanceSummaryTest.java 8395476
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/TestngListener.java b1a2393
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatFeedOperationsTest.java 2a4a9c1
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/hcat/HCatReplicationTest.java af1a751
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/EntitySummaryTest.java 63f98f2
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/LineageApiTest.java cfe1119
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/lineage/ListFeedInstancesTest.java b585665
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/FeedDelayParallelTimeoutTest.java 4ffc64f
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedDeleteTest.java 1d3f88d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationPartitionExpTest.java bde4e65
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedReplicationUpdateTest.java 76345e0
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedSnSTest.java 1cf44b7
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismFeedUpdateTest.java 902ec23
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/PrismSubmitTest.java 279dc56
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RescheduleKilledProcessTest.java 4a0c10e
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ui/LineageGraphTest.java 51fcb8d
> falcon-regression/pom.xml c204d14
>
> Diff: https://reviews.apache.org/r/28424/diff/
>
>
> Testing
> -------
>
> I have done some testing as I made changes but complete ground was not covered.
>
>
> Thanks,
>
> Raghav Gautam
>
>