You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/09/21 20:35:32 UTC

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11634: Make integration tests using test suites

xiangfu0 commented on code in PR #11634:
URL: https://github.com/apache/pinot/pull/11634#discussion_r1333574612


##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/FloatingPointDataTypeTest.java:
##########
@@ -39,7 +39,7 @@
 /**
  * Integration test for floating point data type (float & double) filter queries.
  */
-@Test(suiteName = "CustomClusterIntegrationTest")
+@Test(suiteName = "CustomClusterIntegrationTest", groups = {"custom-integration-suite"})

Review Comment:
   Only this package has the suite implementation, which is already tested using `mvn test -P github-actions,custom-cluster-integration-test-suite || exit 1`. But in this case, we are missing the code coverage report for this.
   So just wanna merge these two suite to run together.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org