You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2011/02/11 09:22:57 UTC
[jira] Created: (HDFS-1624) Append: The condition is incorrect for
checking whether the last block is full
Append: The condition is incorrect for checking whether the last block is full
------------------------------------------------------------------------------
Key: HDFS-1624
URL: https://issues.apache.org/jira/browse/HDFS-1624
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Tsz Wo (Nicholas), SZE
Assignee: Tsz Wo (Nicholas), SZE
When the last block is full, the free space should be 0 but not equal to block size.
{code}
//In DFSOutputStream.DataStreamer.DataStreamer(..),
if (freeInLastBlock == blockSize) {
throw new IOException("The last block for file " +
src + " is full.");
}
{code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1624) Append: The condition is incorrect
for checking whether the last block is full
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993413#comment-12993413 ]
Hadoop QA commented on HDFS-1624:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12470845/h1624_20110211.patch
against trunk revision 1069561.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestFileConcurrentReader
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/160//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/160//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/160//console
This message is automatically generated.
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1624) Append: The condition is incorrect
for checking whether the last block is full
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227128#comment-13227128 ]
Hudson commented on HDFS-1624:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #662 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/662/])
HDFS-1624, HADOOP-7454 - Merge r1296540 from trunk to 0.23 to fix CHANGES.txt (Revision 1299415)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299415
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1624) Append: The condition is incorrect for
checking whether the last block is full
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1624:
-----------------------------------------
Attachment: h1624_20110211.patch
h1624_20110211.patch: fixing the condition.
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1624) Append: The condition is incorrect
for checking whether the last block is full
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227133#comment-13227133 ]
Hudson commented on HDFS-1624:
------------------------------
Integrated in Hadoop-Common-0.23-Commit #671 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/671/])
HDFS-1624, HADOOP-7454 - Merge r1296540 from trunk to 0.23 to fix CHANGES.txt (Revision 1299415)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299415
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1624) Append: The condition is incorrect for
checking whether the last block is full
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1624:
-----------------------------------------
Resolution: Invalid
Status: Resolved (was: Patch Available)
This is invalid (just a bad variable name.)
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HDFS-1624) Append: The condition is incorrect for
checking whether the last block is full
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HDFS-1624:
-----------------------------------------
Affects Version/s: 0.23.0
0.22.0
0.21.0
Status: Patch Available (was: Open)
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1624) Append: The condition is incorrect
for checking whether the last block is full
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227476#comment-13227476 ]
Hudson commented on HDFS-1624:
------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #195 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/195/])
HDFS-1624, HADOOP-7454 - Merge r1296540 from trunk to 0.23 to fix CHANGES.txt (Revision 1299415)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299415
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1624) Append: The condition is incorrect
for checking whether the last block is full
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227215#comment-13227215 ]
Hudson commented on HDFS-1624:
------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #679 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/679/])
HDFS-1624, HADOOP-7454 - Merge r1296540 from trunk to 0.23 to fix CHANGES.txt (Revision 1299415)
Result = ABORTED
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299415
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1624) Append: The condition is incorrect
for checking whether the last block is full
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227499#comment-13227499 ]
Hudson commented on HDFS-1624:
------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #223 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/223/])
HDFS-1624, HADOOP-7454 - Merge r1296540 from trunk to 0.23 to fix CHANGES.txt (Revision 1299415)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299415
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1624) Append: The condition is incorrect
for checking whether the last block is full
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993390#comment-12993390 ]
Todd Lipcon commented on HDFS-1624:
-----------------------------------
What are the ramifications of this bug? Can you write a unit test that shows the problem?
> Append: The condition is incorrect for checking whether the last block is full
> ------------------------------------------------------------------------------
>
> Key: HDFS-1624
> URL: https://issues.apache.org/jira/browse/HDFS-1624
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0, 0.22.0, 0.23.0
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1624_20110211.patch
>
>
> When the last block is full, the free space should be 0 but not equal to block size.
> {code}
> //In DFSOutputStream.DataStreamer.DataStreamer(..),
> if (freeInLastBlock == blockSize) {
> throw new IOException("The last block for file " +
> src + " is full.");
> }
> {code}
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira