[GitHub] ashb commented on a change in pull request #4613: [AIRFLOW-3749] Fix Edit Dag Run page when using RBAC

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4613: [AIRFLOW-3749] Fix Edit Dag Run page when using RBAC
URL: https://github.com/apache/airflow/pull/4613#discussion_r251880146
 
 

 ##########
 File path: airflow/www/templates/airflow/dag.html
 ##########
 @@ -521,7 +521,7 @@ <h4 class="modal-title" id="dagModalLabel">
     });
 
     $('#btn_edit_dagrun').click(function() {
-      window.location = "{{ url_for('DagModelView.show', pk=dag.dag_id) }}";
+      window.location = "{{ url_for('DagModelView.edit', pk=dag.dag_id) }}";
 
 Review comment:
   Not a comment on this PR, but why is this in JS - couldn't it just be a normal HTML link.
   
   (JS that could be written as plain HTML is a bug bear of mine)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services