You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2019/04/29 16:12:05 UTC
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13176
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures
in ASAN builds
Fixed the buffer overflow failure.
Testing:
Tests in parquet-plain-test.cc pass with ASAN enabled.
Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
---
M be/src/exec/parquet/parquet-common.h
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13176/2
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13176 )
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
Patch Set 2: Code-Review+1
Seems ok to me, will give +2 once the full ASAN tests ran.
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 16:13:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13176 )
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2970/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 18:51:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13176 )
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2966/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 16:34:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13176 )
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 23:41:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13176 )
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures
in ASAN builds
Fixed the buffer overflow failure.
Testing:
All BE tests passed with ASAN.
Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Reviewed-on: http://gerrit.cloudera.org:8080/13176
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/parquet/parquet-common.h
1 file changed, 13 insertions(+), 1 deletion(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13176 )
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4103/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 18:13:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13176 )
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures
in ASAN builds
Fixed the buffer overflow failure.
Testing:
All BE tests passed with ASAN.
Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
---
M be/src/exec/parquet/parquet-common.h
1 file changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13176/3
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13176 )
Change subject: IMPALA-8467: ParquetPlainEncoder::Decode leads to multiple test failures in ASAN builds
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ac77f5f135f063bf6b8f7406d5b41535190d5a2
Gerrit-Change-Number: 13176
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2019 18:13:02 +0000
Gerrit-HasComments: No