[GitHub] [cassandra] dcapwell commented on a change in pull request #285: CASSANDRA-14788 Code coverage with CircleCI - against 2.2

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #285: CASSANDRA-14788 Code coverage with CircleCI - against 2.2 
URL: https://github.com/apache/cassandra/pull/285#discussion_r373078453
 
 

 ##########
 File path: .circleci/config.yml
 ##########
 @@ -1,4 +1,55 @@
-default_env_vars: &default_env_vars
+---
 
 Review comment:
   This file is auto generated via `generate.sh` but don't see `config-2.2.yml` modified (or the patch file).  Can you make sure to make the changes in `config-2.2.yml`?
   
   https://github.com/apache/cassandra/blob/trunk/.circleci/readme.md
   
   Here is what I did last time
   
   ```
   cd .circleci
   BASEDIR=$PWD
   
   # If changing CCM settings or modifying the executors, perform the following
   # apply the patch before modifying config-2_1.yml if you are modifying the top part of the file; if touching after the executors are defined then can modify just the config-2_1.ym file and ignore the step of applying the patch and diff
   patch -o $BASEDIR/config-2_1.yml.HIGHRES $BASEDIR/config-2_1.yml $BASEDIR/config-2_1.yml.high_res.patch
   diff config-2_1.yml config-2_1.yml.HIGHRES > config-2_1.yml.high_res.patch
   
   # make the changes required then generate and update defaults
   ./generate.sh
   cp config.yml.LOWRES config.yml
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org