[GitHub] [systemds] kev-inn commented on a diff in pull request #1665: [SYSTEMDS-3405] Write matrices and frames at site for federated write

[GitBox <gi...@apache.org>]

kev-inn commented on code in PR #1665:
URL: https://github.com/apache/systemds/pull/1665#discussion_r922877822


##########
src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedData.java:
##########
@@ -105,6 +105,10 @@ public long getVarID() {
 		return _varID;
 	}
 
+	public void setFilepath(String filepath) {
+		_filepath = filepath;
+	}
+

Review Comment:
   We might want to keep `FederatedData` constant and create a copy with a different filepath instead. I am open for discussion.



##########
src/main/java/org/apache/sysds/runtime/instructions/fed/FEDInstructionUtils.java:
##########
@@ -232,12 +232,7 @@ else if((tinst.input1.isMatrix() && ec.getCacheableData(tinst.input1).isFederate
 			}
 			else if(inst instanceof VariableCPInstruction ){
 				VariableCPInstruction ins = (VariableCPInstruction) inst;
-				if(ins.getVariableOpcode() == VariableOperationCode.Write
-					&& ins.getInput1().isMatrix()
-					&& ins.getInput3().getName().contains("federated")){
-					fedinst = VariableFEDInstruction.parseInstruction(ins);
-				}
-				else if(ins.getVariableOpcode() == VariableOperationCode.CastAsFrameVariable
+				if(ins.getVariableOpcode() == VariableOperationCode.CastAsFrameVariable

Review Comment:
   The federated writing happens inside the `CacheableData<T>.exportData()` method, therefore we don't need to replace the `VariableCPInstruction`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org