You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Dominik Psenner <dp...@gmail.com> on 2017/06/30 15:48:27 UTC
[log4net] pull request #11
Hi
While working on the Jenkinsfile so that jjenkins builds all kinds of
branches for us I noticed that pr-11 made it into master without us carving
out a release. The change is no big deal and I just pushed changes to
master too in order to have jenkins build that branch for us. Is this
change intended? If not, should we rewind master to a previous commit so
long this change is not published?
Cheers
--
Dominik Psenner
Re: [log4net] pull request #11
Posted by Dominik Psenner <dp...@gmail.com>.
Sounds like a plan that is fine with me given that this is just a minor
change.
2017-07-01 18:22 GMT+02:00 Stefan Bodewig <bo...@apache.org>:
> On 2017-06-30, Dominik Psenner wrote:
>
> > While working on the Jenkinsfile so that jjenkins builds all kinds of
> > branches for us I noticed that pr-11 made it into master without us
> carving
> > out a release.
>
> It's been my fault. I committed it to master out of habit and merged it
> to develop later when I realized my mistake.
>
> > If not, should we rewind master to a previous commit so long this
> > change is not published?
>
> It has been pushed to master and synced to github already. We can't know
> whether anybody has checked them out already. Force pushing in order to
> rewind the branch doesn't sound like a good idea to me. I'd leave them
> in master until we cut the next release.
>
> Stefan
>
--
Dominik Psenner
Re: [log4net] pull request #11
Posted by Stefan Bodewig <bo...@apache.org>.
On 2017-06-30, Dominik Psenner wrote:
> While working on the Jenkinsfile so that jjenkins builds all kinds of
> branches for us I noticed that pr-11 made it into master without us carving
> out a release.
It's been my fault. I committed it to master out of habit and merged it
to develop later when I realized my mistake.
> If not, should we rewind master to a previous commit so long this
> change is not published?
It has been pushed to master and synced to github already. We can't know
whether anybody has checked them out already. Force pushing in order to
rewind the branch doesn't sound like a good idea to me. I'd leave them
in master until we cut the next release.
Stefan