You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/10 23:58:10 UTC

[GitHub] [arrow] houqp commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

houqp commented on pull request #7666:
URL: https://github.com/apache/arrow/pull/7666#issuecomment-656943172


   +1 on unifying to Arc for the initial release given it's not on the hot path. It's better to start simple and optimize later. Arc's atomic reference counting tend to mess with compiler optimization and CPU cacheline, so it definitely has extra runtime overhead. But it shouldn't matter for schema. If get schema turned out to be on the hot path, then we have a bigger problem to fix :P I can't think of any reason why that should be the case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org