You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2019/03/20 21:27:59 UTC

[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #140: Fix missing close call for Avro with container reuse.

rdsr commented on a change in pull request #140: Fix missing close call for Avro with container reuse.
URL: https://github.com/apache/incubator-iceberg/pull/140#discussion_r267553810
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/avro/AvroIterable.java
 ##########
 @@ -80,12 +80,12 @@
       reader = new AvroRangeIterator<>(reader, start, end);
     }
 
+    addCloseable(reader);
 
 Review comment:
   nice catch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org