[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

["mbalassi (via GitHub)" <gi...@apache.org>]

mbalassi commented on code in PR #548:
URL: https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1134642722


##########
flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java:
##########
@@ -57,14 +58,14 @@ public void stopAndCleanupCluster(String clusterId) {
                 .apps()
                 .deployments()
                 .withName(StandaloneKubernetesUtils.getJobManagerDeploymentName(clusterId))
-                .cascading(true)
+                .withPropagationPolicy(DeletionPropagation.ORPHAN)

Review Comment:
   @usamj could you please confirm that this was the intention here.



##########
flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java:
##########
@@ -57,14 +58,14 @@ public void stopAndCleanupCluster(String clusterId) {
                 .apps()
                 .deployments()
                 .withName(StandaloneKubernetesUtils.getJobManagerDeploymentName(clusterId))
-                .cascading(true)
+                .withPropagationPolicy(DeletionPropagation.ORPHAN)

Review Comment:
   @usamj could you please confirm that this was the intention here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org