You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/05/03 20:39:02 UTC
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #537: [YUNIKORN-1716] Improve the performance of baseNodeCollection.getNodeIteratorInternal()
codecov[bot] commented on PR #537:
URL: https://github.com/apache/yunikorn-core/pull/537#issuecomment-1533710549
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#537](https://app.codecov.io/gh/apache/yunikorn-core/pull/537?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f92dfb7) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/24ea4f36ba7997bcb96bf0ab192696f4098f1276?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24ea4f3) will **increase** coverage by `0.02%`.
> The diff coverage is `77.96%`.
> :exclamation: Current head f92dfb7 differs from pull request most recent head f584689. Consider uploading reports for the commit f584689 to get more accurate results
```diff
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
+ Coverage 75.05% 75.07% +0.02%
==========================================
Files 70 71 +1
Lines 11328 11390 +62
==========================================
+ Hits 8502 8551 +49
- Misses 2529 2540 +11
- Partials 297 299 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/node\_collection.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGVfY29sbGVjdGlvbi5nbw==) | `90.38% <66.66%> (-3.24%)` | :arrow_down: |
| [pkg/scheduler/objects/sorted\_nodes\_cache.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3NvcnRlZF9ub2Rlc19jYWNoZS5nbw==) | `80.55% <80.55%> (ø)` | |
| [pkg/scheduler/objects/node.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `82.36% <100.00%> (+0.24%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-core/pull/537/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org