You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/01/14 19:37:47 UTC
[GitHub] [guacamole-manual] dstndstn opened a new pull request #180: GUACAMOLE-1501: Makefile: use `find` in a POSIX-compatible way.
dstndstn opened a new pull request #180:
URL: https://github.com/apache/guacamole-manual/pull/180
Instead of using -path, pass paths as regular arguments. This is POSIX-compatible.
Without this, the `find` call fails on Mac OSX 10.15:
find: illegal option -- p
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-manual] dstndstn commented on a change in pull request #180: GUACAMOLE-1501: Makefile: use `find` in a POSIX-compatible way.
Posted by GitBox <gi...@apache.org>.
dstndstn commented on a change in pull request #180:
URL: https://github.com/apache/guacamole-manual/pull/180#discussion_r786000523
##########
File path: Makefile
##########
@@ -33,16 +33,16 @@ clean:
$(RM) -R build/
# All files which the build depends on
-MD_FILES=$(shell find -path "./src/*" -name "*.md")
-RST_FILES=$(shell find -path "./src/*" -name "*.rst")
-PNG_FILES=$(shell find -path "./src/*" -name "*.png")
+MD_FILES=$(shell find ./src -name "*.md")
+RST_FILES=$(shell find ./src -name "*.rst")
+PNG_FILES=$(shell find ./src -name "*.png")
Review comment:
1. Is totally gratuitous since there are no variable expansions, wildcards, or anything going on, but whatever floats your boat (I committed this change with an incorrectly formatted commit message, then tried to fix it and made a mess of the history, oops)
2. Nope, I don't think so. `find -path "./src/*"` says "search in `.` for paths matching `./src/*`" while `find "./src/"` says "search in `./src/`", so the latter would avoid even searching in other directories in `.` other than `src`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-manual] necouchman commented on a change in pull request #180: GUACAMOLE-1501: Makefile: use `find` in a POSIX-compatible way.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #180:
URL: https://github.com/apache/guacamole-manual/pull/180#discussion_r785222854
##########
File path: Makefile
##########
@@ -33,16 +33,16 @@ clean:
$(RM) -R build/
# All files which the build depends on
-MD_FILES=$(shell find -path "./src/*" -name "*.md")
-RST_FILES=$(shell find -path "./src/*" -name "*.rst")
-PNG_FILES=$(shell find -path "./src/*" -name "*.png")
+MD_FILES=$(shell find ./src -name "*.md")
+RST_FILES=$(shell find ./src -name "*.rst")
+PNG_FILES=$(shell find ./src -name "*.png")
Review comment:
Two concerns I have, here:
1. Might still be good to quote the paths.
2. Are there going to be any side effects to omitting the wildcard on the `src/*` path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org