You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by la...@apache.org on 2008/04/02 12:10:00 UTC
svn commit: r643827 - in /webservices/axis2/trunk/c/axiom/src/soap:
soap_fault_detail.c soap_fault_node.c soap_fault_reason.c
Author: lahiru
Date: Wed Apr 2 03:09:50 2008
New Revision: 643827
URL: http://svn.apache.org/viewvc?rev=643827&view=rev
Log:
Hackathon:code improvements
Modified:
webservices/axis2/trunk/c/axiom/src/soap/soap_fault_detail.c
webservices/axis2/trunk/c/axiom/src/soap/soap_fault_node.c
webservices/axis2/trunk/c/axiom/src/soap/soap_fault_reason.c
Modified: webservices/axis2/trunk/c/axiom/src/soap/soap_fault_detail.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/axiom/src/soap/soap_fault_detail.c?rev=643827&r1=643826&r2=643827&view=diff
==============================================================================
--- webservices/axis2/trunk/c/axiom/src/soap/soap_fault_detail.c (original)
+++ webservices/axis2/trunk/c/axiom/src/soap/soap_fault_detail.c Wed Apr 2 03:09:50 2008
@@ -66,16 +66,20 @@
fault_detail = axiom_soap_fault_detail_create(env);
if (!fault_detail)
+ {
return NULL;
-
+ }
parent_node = axiom_soap_fault_get_base_node(fault, env);
if (!parent_node)
+ {
return NULL;
-
+ }
parent_ele =
(axiom_element_t *) axiom_node_get_data_element(parent_node, env);
if (!parent_ele)
+ {
return NULL;
+ }
soap_version = axiom_soap_fault_get_soap_version(fault, env);
if (soap_version == AXIOM_SOAP12)
{
Modified: webservices/axis2/trunk/c/axiom/src/soap/soap_fault_node.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/axiom/src/soap/soap_fault_node.c?rev=643827&r1=643826&r2=643827&view=diff
==============================================================================
--- webservices/axis2/trunk/c/axiom/src/soap/soap_fault_node.c (original)
+++ webservices/axis2/trunk/c/axiom/src/soap/soap_fault_node.c Wed Apr 2 03:09:50 2008
@@ -66,8 +66,9 @@
fault_node = axiom_soap_fault_node_create(env);
if (!fault_node)
+ {
return NULL;
-
+ }
parent_node = axiom_soap_fault_get_base_node(fault, env);
if (!parent_node)
{
Modified: webservices/axis2/trunk/c/axiom/src/soap/soap_fault_reason.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/axiom/src/soap/soap_fault_reason.c?rev=643827&r1=643826&r2=643827&view=diff
==============================================================================
--- webservices/axis2/trunk/c/axiom/src/soap/soap_fault_reason.c (original)
+++ webservices/axis2/trunk/c/axiom/src/soap/soap_fault_reason.c Wed Apr 2 03:09:50 2008
@@ -78,8 +78,9 @@
fault_reason = axiom_soap_fault_reason_create(env);
if (!fault_reason)
+ {
return NULL;
-
+ }
parent_node = axiom_soap_fault_get_base_node(fault, env);
if (!parent_node)
{
@@ -158,8 +159,9 @@
AXIS2_PARAM_CHECK(env->error, fault_reason, NULL);
if (!lang || (axutil_strcmp(lang, "") == 0))
+ {
return NULL;
-
+ }
/** Here we have to build the soap fault reason element completly */
if (!fault_reason->fault_texts)
{
@@ -172,14 +174,17 @@
status =
axiom_soap_builder_next(fault_reason->soap_builder, env);
if (status == AXIS2_FAILURE)
+ {
return NULL;
+ }
}
}
}
if (!fault_reason->fault_texts)
+ {
return NULL;
-
+ }
/** iterate the array list */
size = axutil_array_list_size(fault_reason->fault_texts, env);
for (i = 0; i < size; i++)
@@ -255,7 +260,9 @@
status =
axiom_soap_builder_next(fault_reason->soap_builder, env);
if (status == AXIS2_FAILURE)
+ {
return NULL;
+ }
}
}
}
@@ -278,7 +285,9 @@
status =
axiom_soap_builder_next(fault_reason->soap_builder, env);
if (status == AXIS2_FAILURE)
+ {
return NULL;
+ }
}
}
}
@@ -287,7 +296,9 @@
void *value = NULL;
value = axutil_array_list_get(fault_reason->fault_texts, env, 0);
if (value)
+ {
return (axiom_soap_fault_text_t *) value;
+ }
}
return NULL;
}
@@ -299,13 +310,16 @@
axiom_soap_fault_text_t * fault_text)
{
if (!fault_text)
+ {
return AXIS2_FAILURE;
-
+ }
if (!(fault_reason->fault_texts))
{
fault_reason->fault_texts = axutil_array_list_create(env, 1);
if (!fault_reason->fault_texts)
+ {
return AXIS2_FAILURE;
+ }
axutil_array_list_add(fault_reason->fault_texts, env, fault_text);
}
else
@@ -318,8 +332,9 @@
is_exists =
axiom_soap_fault_reason_lang_exists(fault_reason, env, lang);
if (is_exists == AXIS2_TRUE)
+ {
return AXIS2_FAILURE;
-
+ }
/** this soap_fault text already exists */
}
axutil_array_list_add(fault_reason->fault_texts, env, fault_text);
@@ -337,8 +352,9 @@
int i = 0;
if (!lang || (axutil_strcmp(lang, "") == 0) || !fault_reason->fault_texts)
+ {
return AXIS2_FALSE;
-
+ }
size = axutil_array_list_size(fault_reason->fault_texts, env);
for (i = 0; i < size; i++)
{
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org