You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Robert Meyer <rm...@hotmail.co.uk> on 2014/05/14 11:22:21 UTC
[VOTE] Add Type 1 subset support
Hi All,
Following on from the last failed vote for adding Type 1 subset support, I have now put forward a modified patch and am ready to try this again. The patch went up on Monday to address the issues and comments made by Vincent and Luis. This vote will last 5 working days and will finish next Wednesday at the same time.
As always if you have any concerns or find anything please let me know. If they are small I will try and address the issue before the vote is finalized in order to avoid repeating this again. Please note that all type 1 fonts will default to full embedding unless you use the embedding-mode="subset" as per one of the recommendations from the last vote.
Here is my vote: +1
Best Regards,
Robert Meyer
RE: [VOTE] Add Type 1 subset support
Posted by Robert Meyer <rm...@hotmail.co.uk>.
Hi,
Thanks all for voting. The vote has now concluded and has passed with 6 +1 votes.
I will look at merging this patch with trunk and update the necessary documentation soon.
To reiterate, the default for Type 1 fonts will be to fully embed unless explicitly stated otherwise in the configuration.
Regards,
Robert Meyer
> Date: Tue, 20 May 2014 11:26:23 +0100
> From: vhennebert@gmail.com
> To: fop-dev@xmlgraphics.apache.org
> Subject: Re: [VOTE] Add Type 1 subset support
>
> The code has certainly improved since last time. Now glyph names are
> being used directly, without any round-trip to Unicode code point and
> back to character code. This is great as it simplifies the code quite
> a bit and makes it more robust.
>
> The PostScript parser hasn’t changed so my concerns about its resilience
> against ill-formed fonts remain. Also, while memory usage has improved
> a bit, there still seems to be unwarranted copying of byte arrays here
> and there. For example, the creation of the encrypted portion could be
> made on the fly by wrapping the output stream into a FilterOutputStream.
>
> Overall there is room for further streamlining and simplifying the code.
> But since it’s an optional feature I suppose there is no harm in letting
> interested users experiment with it. So I’ll vote +1.
>
> Thanks,
> Vincent
>
>
> On 14/05/14 10:22, Robert Meyer wrote:
> > Hi All,
> >
> > Following on from the last failed vote for adding Type 1 subset support, I have now put forward a modified patch and am ready to try this again. The patch went up on Monday to address the issues and comments made by Vincent and Luis. This vote will last 5 working days and will finish next Wednesday at the same time.
> >
> > As always if you have any concerns or find anything please let me know. If they are small I will try and address the issue before the vote is finalized in order to avoid repeating this again. Please note that all type 1 fonts will default to full embedding unless you use the embedding-mode="subset" as per one of the recommendations from the last vote.
> >
> > Here is my vote: +1
> >
> > Best Regards,
> >
> > Robert Meyer
> >
> >
Re: [VOTE] Add Type 1 subset support
Posted by Vincent Hennebert <vh...@gmail.com>.
The code has certainly improved since last time. Now glyph names are
being used directly, without any round-trip to Unicode code point and
back to character code. This is great as it simplifies the code quite
a bit and makes it more robust.
The PostScript parser hasn’t changed so my concerns about its resilience
against ill-formed fonts remain. Also, while memory usage has improved
a bit, there still seems to be unwarranted copying of byte arrays here
and there. For example, the creation of the encrypted portion could be
made on the fly by wrapping the output stream into a FilterOutputStream.
Overall there is room for further streamlining and simplifying the code.
But since it’s an optional feature I suppose there is no harm in letting
interested users experiment with it. So I’ll vote +1.
Thanks,
Vincent
On 14/05/14 10:22, Robert Meyer wrote:
> Hi All,
>
> Following on from the last failed vote for adding Type 1 subset support, I have now put forward a modified patch and am ready to try this again. The patch went up on Monday to address the issues and comments made by Vincent and Luis. This vote will last 5 working days and will finish next Wednesday at the same time.
>
> As always if you have any concerns or find anything please let me know. If they are small I will try and address the issue before the vote is finalized in order to avoid repeating this again. Please note that all type 1 fonts will default to full embedding unless you use the embedding-mode="subset" as per one of the recommendations from the last vote.
>
> Here is my vote: +1
>
> Best Regards,
>
> Robert Meyer
>
>
Re: [VOTE] Add Type 1 subset support
Posted by Pascal Sancho <ps...@gmail.com>.
Hi,
here is my +1
2014-05-14 11:22 GMT+02:00 Robert Meyer <rm...@hotmail.co.uk>:
> Hi All,
>
> Following on from the last failed vote for adding Type 1 subset support, I
> have now put forward a modified patch and am ready to try this again. The
> patch went up on Monday to address the issues and comments made by Vincent
> and Luis. This vote will last 5 working days and will finish next Wednesday
> at the same time.
>
> As always if you have any concerns or find anything please let me know. If
> they are small I will try and address the issue before the vote is finalized
> in order to avoid repeating this again. Please note that all type 1 fonts
> will default to full embedding unless you use the embedding-mode="subset" as
> per one of the recommendations from the last vote.
>
> Here is my vote: +1
>
> Best Regards,
>
> Robert Meyer
--
pascal
RE: [VOTE] Add Type 1 subset support
Posted by Simon Steiner <si...@gmail.com>.
Hi,
+1
Thanks
From: Luis Bernardo [mailto:lmpmbernardo@gmail.com]
Sent: 18 May 2014 00:19
To: fop-dev@xmlgraphics.apache.org
Subject: Re: [VOTE] Add Type 1 subset support
+1
It would be desirable to add the six letter prefix to the font name so that
Adobe Reader (and other viewers) flag the font as being subset. But I tested
with new fonts and worked well.
On 5/14/14, 10:22 AM, Robert Meyer wrote:
Hi All,
Following on from the last failed vote for adding Type 1 subset support, I
have now put forward a modified patch and am ready to try this again. The
patch went up on Monday to address the issues and comments made by Vincent
and Luis. This vote will last 5 working days and will finish next Wednesday
at the same time.
As always if you have any concerns or find anything please let me know. If
they are small I will try and address the issue before the vote is finalized
in order to avoid repeating this again. Please note that all type 1 fonts
will default to full embedding unless you use the embedding-mode="subset" as
per one of the recommendations from the last vote.
Here is my vote: +1
Best Regards,
Robert Meyer
Re: [VOTE] Add Type 1 subset support
Posted by Luis Bernardo <lm...@gmail.com>.
+1
It would be desirable to add the six letter prefix to the font name so
that Adobe Reader (and other viewers) flag the font as being subset. But
I tested with new fonts and worked well.
On 5/14/14, 10:22 AM, Robert Meyer wrote:
> Hi All,
>
> Following on from the last failed vote for adding Type 1 subset
> support, I have now put forward a modified patch and am ready to try
> this again. The patch went up on Monday to address the issues and
> comments made by Vincent and Luis. This vote will last 5 working days
> and will finish next Wednesday at the same time.
>
> As always if you have any concerns or find anything please let me
> know. If they are small I will try and address the issue before the
> vote is finalized in order to avoid repeating this again. Please note
> that all type 1 fonts will default to full embedding unless you use
> the embedding-mode="subset" as per one of the recommendations from the
> last vote.
>
> Here is my vote: +1
>
> Best Regards,
>
> Robert Meyer
Re: [VOTE] Add Type 1 subset support
Posted by Glenn Adams <gl...@skynav.com>.
+1 here too
On Wed, May 21, 2014 at 11:20 PM, Chris Bowditch <bowditch_chris@hotmail.com
> wrote:
> Hi Rob,
>
> Thanks for preparing the stats. 39% is quiet a leap and in that case I
> agree it makes sense not to subset by default. It looks like I missed the
> vote now, sorry about that. But I'm +1
>
> Thanks,
>
> Chris
>
> On 16/05/2014 17:20, Robert Meyer wrote:
>
>> Hi Chris,
>>
>> Here are some performance statistics for three different types of fonts:
>>
>> TrueType:
>> Full = 1123ms
>> Subset = 1137ms
>> Difference = 1.2%
>>
>> OpenType:
>> Full = 3497ms
>> Subset = 3512ms
>> Difference = 0.4%
>>
>> Type 1:
>> Full = 1148ms
>> Subset = 1896ms
>> Difference = 39%
>>
>> The reason for this can be easily explained. Type 1 fonts contain
>> Postscript code. OpenType and TrueType do not as they only contain binary
>> data. This means no special effort by them has to be made to parse,
>> understand and reconstruct what is effectively another high level
>> programming language.
>>
>> Because of this deficit, it may be best to leave it as an option as per
>> Vincent's suggestion unless the user wants to create a smaller file and
>> incur the hit. In the meantime I could investigate in the near future
>> whether any performance improvements could be made to speed up the process.
>> It's likely though this will never result in it being close to either OTF
>> or TTF levels of performance.
>>
>> Best Regards,
>>
>> Robert
>>
>> > Date: Fri, 16 May 2014 08:33:52 +0100
>> > From: bowditch_chris@hotmail.com
>> > To: fop-dev@xmlgraphics.apache.org
>> > Subject: Re: [VOTE] Add Type 1 subset support
>> >
>> > Hi Rob,
>> >
>> > You've done a great job in developing this feature. Before voting though
>> > I'd like to understand why the default is not to subset Type 1 fonts.
>> > Most users will want the smallest output file size possible. Not
>> > enabling it by default is also inconsistent with True Type fonts, whose
>> > default is to subset. This inconsistency could lead to confusion.
>> >
>> > Thanks,
>> >
>> > Chris
>> >
>> > On 14/05/2014 10:22, Robert Meyer wrote:
>> > > Hi All,
>> > >
>> > > Following on from the last failed vote for adding Type 1 subset
>> > > support, I have now put forward a modified patch and am ready to try
>> > > this again. The patch went up on Monday to address the issues and
>> > > comments made by Vincent and Luis. This vote will last 5 working days
>> > > and will finish next Wednesday at the same time.
>> > >
>> > > As always if you have any concerns or find anything please let me
>> > > know. If they are small I will try and address the issue before the
>> > > vote is finalized in order to avoid repeating this again. Please note
>> > > that all type 1 fonts will default to full embedding unless you use
>> > > the embedding-mode="subset" as per one of the recommendations from the
>> > > last vote.
>> > >
>> > > Here is my vote: +1
>> > >
>> > > Best Regards,
>> > >
>> > > Robert Meyer
>> >
>>
>
>
Re: [VOTE] Add Type 1 subset support
Posted by Chris Bowditch <bo...@hotmail.com>.
Hi Rob,
Thanks for preparing the stats. 39% is quiet a leap and in that case I
agree it makes sense not to subset by default. It looks like I missed
the vote now, sorry about that. But I'm +1
Thanks,
Chris
On 16/05/2014 17:20, Robert Meyer wrote:
> Hi Chris,
>
> Here are some performance statistics for three different types of fonts:
>
> TrueType:
> Full = 1123ms
> Subset = 1137ms
> Difference = 1.2%
>
> OpenType:
> Full = 3497ms
> Subset = 3512ms
> Difference = 0.4%
>
> Type 1:
> Full = 1148ms
> Subset = 1896ms
> Difference = 39%
>
> The reason for this can be easily explained. Type 1 fonts contain
> Postscript code. OpenType and TrueType do not as they only contain
> binary data. This means no special effort by them has to be made to
> parse, understand and reconstruct what is effectively another high
> level programming language.
>
> Because of this deficit, it may be best to leave it as an option as
> per Vincent's suggestion unless the user wants to create a smaller
> file and incur the hit. In the meantime I could investigate in the
> near future whether any performance improvements could be made to
> speed up the process. It's likely though this will never result in it
> being close to either OTF or TTF levels of performance.
>
> Best Regards,
>
> Robert
>
> > Date: Fri, 16 May 2014 08:33:52 +0100
> > From: bowditch_chris@hotmail.com
> > To: fop-dev@xmlgraphics.apache.org
> > Subject: Re: [VOTE] Add Type 1 subset support
> >
> > Hi Rob,
> >
> > You've done a great job in developing this feature. Before voting
> though
> > I'd like to understand why the default is not to subset Type 1 fonts.
> > Most users will want the smallest output file size possible. Not
> > enabling it by default is also inconsistent with True Type fonts, whose
> > default is to subset. This inconsistency could lead to confusion.
> >
> > Thanks,
> >
> > Chris
> >
> > On 14/05/2014 10:22, Robert Meyer wrote:
> > > Hi All,
> > >
> > > Following on from the last failed vote for adding Type 1 subset
> > > support, I have now put forward a modified patch and am ready to try
> > > this again. The patch went up on Monday to address the issues and
> > > comments made by Vincent and Luis. This vote will last 5 working days
> > > and will finish next Wednesday at the same time.
> > >
> > > As always if you have any concerns or find anything please let me
> > > know. If they are small I will try and address the issue before the
> > > vote is finalized in order to avoid repeating this again. Please note
> > > that all type 1 fonts will default to full embedding unless you use
> > > the embedding-mode="subset" as per one of the recommendations from
> the
> > > last vote.
> > >
> > > Here is my vote: +1
> > >
> > > Best Regards,
> > >
> > > Robert Meyer
> >
Re: [VOTE] Add Type 1 subset support
Posted by Clay Leeds <th...@gmail.com>.
Thanks for this explanation and the work you’ve done to implement, Robert,
Here’s my +1
On May 16, 2014, at 9:20 AM, Robert Meyer <rm...@hotmail.co.uk> wrote:
> Hi Chris,
>
> Here are some performance statistics for three different types of fonts:
>
> TrueType:
> Full = 1123ms
> Subset = 1137ms
> Difference = 1.2%
>
> OpenType:
> Full = 3497ms
> Subset = 3512ms
> Difference = 0.4%
>
> Type 1:
> Full = 1148ms
> Subset = 1896ms
> Difference = 39%
>
> The reason for this can be easily explained. Type 1 fonts contain Postscript code. OpenType and TrueType do not as they only contain binary data. This means no special effort by them has to be made to parse, understand and reconstruct what is effectively another high level programming language.
>
> Because of this deficit, it may be best to leave it as an option as per Vincent's suggestion unless the user wants to create a smaller file and incur the hit. In the meantime I could investigate in the near future whether any performance improvements could be made to speed up the process. It's likely though this will never result in it being close to either OTF or TTF levels of performance.
>
> Best Regards,
>
> Robert
>
> > Date: Fri, 16 May 2014 08:33:52 +0100
> > From: bowditch_chris@hotmail.com
> > To: fop-dev@xmlgraphics.apache.org
> > Subject: Re: [VOTE] Add Type 1 subset support
> >
> > Hi Rob,
> >
> > You've done a great job in developing this feature. Before voting though
> > I'd like to understand why the default is not to subset Type 1 fonts.
> > Most users will want the smallest output file size possible. Not
> > enabling it by default is also inconsistent with True Type fonts, whose
> > default is to subset. This inconsistency could lead to confusion.
> >
> > Thanks,
> >
> > Chris
> >
> > On 14/05/2014 10:22, Robert Meyer wrote:
> > > Hi All,
> > >
> > > Following on from the last failed vote for adding Type 1 subset
> > > support, I have now put forward a modified patch and am ready to try
> > > this again. The patch went up on Monday to address the issues and
> > > comments made by Vincent and Luis. This vote will last 5 working days
> > > and will finish next Wednesday at the same time.
> > >
> > > As always if you have any concerns or find anything please let me
> > > know. If they are small I will try and address the issue before the
> > > vote is finalized in order to avoid repeating this again. Please note
> > > that all type 1 fonts will default to full embedding unless you use
> > > the embedding-mode="subset" as per one of the recommendations from the
> > > last vote.
> > >
> > > Here is my vote: +1
> > >
> > > Best Regards,
> > >
> > > Robert Meyer
> >
RE: [VOTE] Add Type 1 subset support
Posted by Robert Meyer <rm...@hotmail.co.uk>.
Hi Chris,
Here are some performance statistics for three different types of fonts:
TrueType:
Full = 1123ms
Subset = 1137ms
Difference = 1.2%
OpenType:
Full = 3497ms
Subset = 3512ms
Difference = 0.4%
Type 1:
Full = 1148ms
Subset = 1896ms
Difference = 39%
The reason for this can be easily explained. Type 1 fonts contain Postscript code. OpenType and TrueType do not as they only contain binary data. This means no special effort by them has to be made to parse, understand and reconstruct what is effectively another high level programming language.
Because of this deficit, it may be best to leave it as an option as per Vincent's suggestion unless the user wants to create a smaller file and incur the hit. In the meantime I could investigate in the near future whether any performance improvements could be made to speed up the process. It's likely though this will never result in it being close to either OTF or TTF levels of performance.
Best Regards,
Robert
> Date: Fri, 16 May 2014 08:33:52 +0100
> From: bowditch_chris@hotmail.com
> To: fop-dev@xmlgraphics.apache.org
> Subject: Re: [VOTE] Add Type 1 subset support
>
> Hi Rob,
>
> You've done a great job in developing this feature. Before voting though
> I'd like to understand why the default is not to subset Type 1 fonts.
> Most users will want the smallest output file size possible. Not
> enabling it by default is also inconsistent with True Type fonts, whose
> default is to subset. This inconsistency could lead to confusion.
>
> Thanks,
>
> Chris
>
> On 14/05/2014 10:22, Robert Meyer wrote:
> > Hi All,
> >
> > Following on from the last failed vote for adding Type 1 subset
> > support, I have now put forward a modified patch and am ready to try
> > this again. The patch went up on Monday to address the issues and
> > comments made by Vincent and Luis. This vote will last 5 working days
> > and will finish next Wednesday at the same time.
> >
> > As always if you have any concerns or find anything please let me
> > know. If they are small I will try and address the issue before the
> > vote is finalized in order to avoid repeating this again. Please note
> > that all type 1 fonts will default to full embedding unless you use
> > the embedding-mode="subset" as per one of the recommendations from the
> > last vote.
> >
> > Here is my vote: +1
> >
> > Best Regards,
> >
> > Robert Meyer
>
Re: [VOTE] Add Type 1 subset support
Posted by Chris Bowditch <bo...@hotmail.com>.
Hi Rob,
You've done a great job in developing this feature. Before voting though
I'd like to understand why the default is not to subset Type 1 fonts.
Most users will want the smallest output file size possible. Not
enabling it by default is also inconsistent with True Type fonts, whose
default is to subset. This inconsistency could lead to confusion.
Thanks,
Chris
On 14/05/2014 10:22, Robert Meyer wrote:
> Hi All,
>
> Following on from the last failed vote for adding Type 1 subset
> support, I have now put forward a modified patch and am ready to try
> this again. The patch went up on Monday to address the issues and
> comments made by Vincent and Luis. This vote will last 5 working days
> and will finish next Wednesday at the same time.
>
> As always if you have any concerns or find anything please let me
> know. If they are small I will try and address the issue before the
> vote is finalized in order to avoid repeating this again. Please note
> that all type 1 fonts will default to full embedding unless you use
> the embedding-mode="subset" as per one of the recommendations from the
> last vote.
>
> Here is my vote: +1
>
> Best Regards,
>
> Robert Meyer