You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "quinnj (via GitHub)" <gi...@apache.org> on 2023/06/12 19:39:44 UTC

[GitHub] [arrow-julia] quinnj commented on a diff in pull request #464: Formatting

quinnj commented on code in PR #464:
URL: https://github.com/apache/arrow-julia/pull/464#discussion_r1227153769


##########
src/FlatBuffers/FlatBuffers.jl:
##########
@@ -24,10 +24,10 @@ const VOffsetT = UInt16
 const VtableMetadataFields = 2
 
 basetype(::Enum) = UInt8
-basetype(::Type{T}) where {T <: Enum{S}} where {S} = S
+basetype(::Type{T}) where {T<:Enum{S}} where {S} = S
 
 function readbuffer(t::AbstractVector{UInt8}, pos::Integer, ::Type{Bool})
-    @inbounds b = t[pos + 1]
+    @inbounds b = t[pos+1]

Review Comment:
   I always prefer spaces around operators



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org