You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2013/07/30 17:36:00 UTC
svn commit: r1508492 - in /subversion/branches/fsx/subversion:
include/svn_sorts.h libsvn_subr/sorts.c
Author: stefan2
Date: Tue Jul 30 15:36:00 2013
New Revision: 1508492
URL: http://svn.apache.org/r1508492
Log:
On the fsx branch: constify the input value to of svn_priority_queue__push
to make the API easier to use.
* subversion/include/svn_sorts.h
(svn_priority_queue__push): accept constant element values
* subversion/libsvn_subr/sorts.c
(svn_priority_queue__push): update
Modified:
subversion/branches/fsx/subversion/include/svn_sorts.h
subversion/branches/fsx/subversion/libsvn_subr/sorts.c
Modified: subversion/branches/fsx/subversion/include/svn_sorts.h
URL: http://svn.apache.org/viewvc/subversion/branches/fsx/subversion/include/svn_sorts.h?rev=1508492&r1=1508491&r2=1508492&view=diff
==============================================================================
--- subversion/branches/fsx/subversion/include/svn_sorts.h (original)
+++ subversion/branches/fsx/subversion/include/svn_sorts.h Tue Jul 30 15:36:00 2013
@@ -282,8 +282,7 @@ svn_priority_queue__pop(svn_priority_que
* #NULL nor the first element as returned by #svn_priority_queue__peek.
*/
void
-svn_priority_queue__push(svn_priority_queue__t *queue,
- void *element);
+svn_priority_queue__push(svn_priority_queue__t* queue, const void* element);
/** @} */
Modified: subversion/branches/fsx/subversion/libsvn_subr/sorts.c
URL: http://svn.apache.org/viewvc/subversion/branches/fsx/subversion/libsvn_subr/sorts.c?rev=1508492&r1=1508491&r2=1508492&view=diff
==============================================================================
--- subversion/branches/fsx/subversion/libsvn_subr/sorts.c (original)
+++ subversion/branches/fsx/subversion/libsvn_subr/sorts.c Tue Jul 30 15:36:00 2013
@@ -444,7 +444,7 @@ svn_priority_queue__pop(svn_priority_que
void
svn_priority_queue__push(svn_priority_queue__t *queue,
- void *element)
+ const void *element)
{
/* we cannot duplicate elements due to potential array re-allocs */
assert(element && element != queue->elements->elts);
Re: svn commit: r1508492 - in /subversion/branches/fsx/subversion:
include/svn_sorts.h libsvn_subr/sorts.c
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Tue, Jul 30, 2013 at 8:54 PM, Greg Stein <gs...@gmail.com> wrote:
> On Tue, Jul 30, 2013 at 11:36 AM, <st...@apache.org> wrote:
> >...
> > +++ subversion/branches/fsx/subversion/include/svn_sorts.h Tue Jul 30
> 15:36:00 2013
> > @@ -282,8 +282,7 @@ svn_priority_queue__pop(svn_priority_que
> > * #NULL nor the first element as returned by #svn_priority_queue__peek.
> > */
> > void
> > -svn_priority_queue__push(svn_priority_queue__t *queue,
> > - void *element);
> > +svn_priority_queue__push(svn_priority_queue__t* queue, const void*
> element);
>
> Nit: formatting: ... type *name
>
Thanks for the review!
Fixed in r1509041.
-- Stefan^2
Re: svn commit: r1508492 - in /subversion/branches/fsx/subversion:
include/svn_sorts.h libsvn_subr/sorts.c
Posted by Greg Stein <gs...@gmail.com>.
On Tue, Jul 30, 2013 at 11:36 AM, <st...@apache.org> wrote:
>...
> +++ subversion/branches/fsx/subversion/include/svn_sorts.h Tue Jul 30 15:36:00 2013
> @@ -282,8 +282,7 @@ svn_priority_queue__pop(svn_priority_que
> * #NULL nor the first element as returned by #svn_priority_queue__peek.
> */
> void
> -svn_priority_queue__push(svn_priority_queue__t *queue,
> - void *element);
> +svn_priority_queue__push(svn_priority_queue__t* queue, const void* element);
Nit: formatting: ... type *name