You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/11/18 20:53:32 UTC
[GitHub] [httpcomponents-core] arturobernalg opened a new pull request #332: Do not explicitly declare runtime exceptions.
arturobernalg opened a new pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332
Because that is a "runtime" exception and we don't need to declare it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974627983
I can and I do because I find explicit declaration of exceptions more useful than javadocs. The above statement from Oracle is silly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974323336
I agree with @arturobernalg declaring runtime exceptions are an antipattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974505292
Joshua Bloch, Effective Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974316378
> @arturobernalg I do not find this change-set useful. What does it improve exactly?
HI. @ok2c
Is just a good practice. help to make the code more readable and simple. Imagine that start documenting all the RuntimeExceptions?
TY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974627983
I can and I do because I find explicit declaration of exceptions more useful than javadocs. The above statement from Oracle is silly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974617494
https://docs.oracle.com/javase/tutorial/essential/exceptions/runtime.html
"Having to add runtime exceptions in every method declaration would reduce a program's clarity. Thus, the compiler does not require that you catch or specify runtime exceptions (although you can)."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg closed pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-973989457
@arturobernalg I do not find this change-set useful. What does it improve exactly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c edited a comment on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
ok2c edited a comment on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974522841
> Joshua Bloch, Effective Java
Did he, really? I am quite sure you would not mind providing a quote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974522841
> Joshua Bloch, Effective Java
Did he, really? I am quite sure you wound not mind providing a quote.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974617494
https://docs.oracle.com/javase/tutorial/essential/exceptions/runtime.html
"Having to add runtime exceptions in every method declaration would reduce a program's clarity. Thus, the compiler does not require that you catch or specify runtime exceptions (although you can)."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #332: Do not explicitly declare runtime exceptions.
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #332:
URL: https://github.com/apache/httpcomponents-core/pull/332#issuecomment-974501731
> Is just a good practice.
@arturobernalg @michael-o Who said that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org