You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2015/11/21 16:37:10 UTC
[jira] [Updated] (YETUS-89) Variable name "HOW_TO_CONTRIBUTE" is
misleading
[ https://issues.apache.org/jira/browse/YETUS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kengo Seki updated YETUS-89:
----------------------------
Attachment: YETUS-89.01.patch
Sorry for the late update.
-01:
* rename the variable to PATCH_NAMING_RULE because PATCH_NAMING_RULE_URL feels too long.
* unset PATCH_NAMING_RULE if the personality doesn't have a specific value.
* fix a variable in jira_locate_patch. Another problem I mentioned above is already fixed on master.
* fix the document.
Messages example:
{code}
[sekikn@mobile yetus]$ precommit/test-patch.sh --basedir=../drill --debug --plugins=all,-asflicense,-checkstyle,-findbugs,-javac,-javadoc --project=drill --resetrepo DRILL-3522
(snip)
[Sun Nov 22 00:11:00 JST 2015 DEBUG]: jira_locate_patch: trying https://issues.apache.org/jira/browse/DRILL-3522
DRILL-3522 patch is being downloaded at Sun Nov 22 00:11:01 JST 2015 from
https://issues.apache.org/jira/secure/attachment/12746251/DRILL-3522.1.patch.txt
[Sun Nov 22 00:11:02 JST 2015 DEBUG]: Trying to guess if /private/tmp/yetus-5159.2468/patch is a patch file.
[Sun Nov 22 00:11:02 JST 2015 DEBUG]: first line looks like a patch file.
[Sun Nov 22 00:11:02 JST 2015 DEBUG]: The patch https://issues.apache.org/jira/secure/attachment/12746251/DRILL-3522.1.patch.txt was not named properly, but it looks like a patch file. Proceeding, but issue/branch matching might go awry.
[Sun Nov 22 00:11:02 JST 2015 DEBUG]: Stop clock
[Sun Nov 22 00:11:02 JST 2015 DEBUG]: add_vote_table 0 patch The patch file was not named according to drill's naming conventions. Please see https://drill.apache.org/docs/apache-drill-contribution-guidelines/ for instructions.
(snip)
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | patch | 0m 04s | The patch file was not named according
| | | | to drill's naming conventions. Please see
| | | | https://drill.apache.org/docs/apache-drill
| | | | -contribution-guidelines/ for
| | | | instructions.
| +1 | @author | 0m 00s | The patch does not contain any @author
| | | | tags.
| -1 | test4tests | 0m 00s | The patch doesn't appear to include any
| | | | new or modified tests. Please justify why
| | | | no new tests are needed for this patch.
| | | | Also please list what manual steps were
| | | | performed to verify this patch.
| +1 | whitespace | 0m 00s | Patch has no whitespace issues.
| | | 0m 08s |
|| Subsystem || Report/Notes ||
============================================================================
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12746251/DRILL-3522.1.patch.txt |
| JIRA Issue | DRILL-3522 |
| Optional Tests | unit |
| uname | Darwin mobile.local 15.0.0 Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | /Users/sekikn/yetus/precommit/personality/drill.sh |
| git revision | master / f7a0d38 |
| modules | C: contrib/storage-mongo U: contrib/storage-mongo |
| Powered by | Apache Yetus http://yetus.apache.org |
{code}
> Variable name "HOW_TO_CONTRIBUTE" is misleading
> -----------------------------------------------
>
> Key: YETUS-89
> URL: https://issues.apache.org/jira/browse/YETUS-89
> Project: Yetus
> Issue Type: Bug
> Components: Test Patch
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Trivial
> Labels: newbie
> Attachments: YETUS-89.00.patch, YETUS-89.01.patch
>
>
> {code} HOW_TO_CONTRIBUTE="https://yetus.apache.org/documentation/latest/precommit-patchnames"
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)