You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Charlies Mason (JIRA)" <ji...@apache.org> on 2008/09/18 22:52:44 UTC
[jira] Created: (HBASE-889) The current Thrift API does not allow a
new scanner to be created without supplying a column list unlike the other
APIs.
The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
------------------------------------------------------------------------------------------------------------------------
Key: HBASE-889
URL: https://issues.apache.org/jira/browse/HBASE-889
Project: Hadoop HBase
Issue Type: Bug
Components: thrift
Affects Versions: 0.2.1, 0.2.0
Reporter: Charlies Mason
The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HBASE-889) The current Thrift API does not allow
a new scanner to be created without supplying a column list unlike the
other APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell reopened HBASE-889:
----------------------------
I was wrong, this wasn't fixed by HBASE-1142 after all. I didn't test it properly. Sorry.
You could pass it an empty list, but the scanner would just select zero columns.
Attached is a patch that addresses this, it includes a getAllColumns function which looks them up from the table descriptor.
I'm not convinced this is how it should be done though, because the shell has similar code. Presumably so does the REST api. Maybe the HTable.getScanner functions should do this themselves if passed null or an empty list for columns?
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-889) The current Thrift API does not allow
a new scanner to be created without supplying a column list unlike the
other APIs.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-889:
---------------------------
Assignee: Tim Sell
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-889) The current Thrift API does not allow a
new scanner to be created without supplying a column list unlike the other
APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-889:
---------------------------
Status: Patch Available (was: Reopened)
Here's a slightly cleaner version of the patch against the latest trunk.
btw this does not require changes to the generated code at all.
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.1, 0.2.0
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch, HBASE-889v2.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-889) The current Thrift API does not allow
a new scanner to be created without supplying a column list unlike the
other APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632693#action_12632693 ]
Tim Sell commented on HBASE-889:
--------------------------------
A patch will not be up in a jiffy after all. I do this over the weekend maybe.
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-889) The current Thrift API does not allow
a new scanner to be created without supplying a column list unlike the
other APIs.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-889.
-------------------------
Resolution: Fixed
Fix Version/s: 0.20.0
Fixed by HBASE-1142
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
> Fix For: 0.20.0
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-889) The current Thrift API does not allow a
new scanner to be created without supplying a column list unlike the other
APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-889:
---------------------------
Status: Open (was: Patch Available)
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.1, 0.2.0
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch, HBASE-889v2.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-889) The current Thrift API does not allow
a new scanner to be created without supplying a column list unlike the
other APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666987#action_12666987 ]
Tim Sell commented on HBASE-889:
--------------------------------
That sounds good, we should remove the hack-arounds in that issue.
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-889) The current Thrift API does not allow a
new scanner to be created without supplying a column list unlike the other
APIs.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-889:
------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed. Thanks for the patch Tim (Did you see hbase-1360 and related where upping trunk to use thrift trunk?)
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch, HBASE-889v2.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-889) The current Thrift API does not allow a
new scanner to be created without supplying a column list unlike the other
APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-889:
---------------------------
Status: Patch Available (was: Open)
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.1, 0.2.0
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch, HBASE-889v2.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-889) The current Thrift API does not allow a
new scanner to be created without supplying a column list unlike the other
APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-889:
---------------------------
Attachment: HBASE-889v1.patch
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-889) The current Thrift API does not allow a
new scanner to be created without supplying a column list unlike the other
APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Sell updated HBASE-889:
---------------------------
Attachment: HBASE-889v2.patch
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch, HBASE-889v2.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-889) The current Thrift API does not allow
a new scanner to be created without supplying a column list unlike the
other APIs.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666984#action_12666984 ]
stack commented on HBASE-889:
-----------------------------
Agreed Tim. Null columns list should return all. Shall we apply your patch meantime and then open new issue to do as you suggest?
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
> Assignee: Tim Sell
> Fix For: 0.20.0
>
> Attachments: HBASE-889v1.patch
>
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-889) The current Thrift API does not allow
a new scanner to be created without supplying a column list unlike the
other APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632691#action_12632691 ]
Tim Sell commented on HBASE-889:
--------------------------------
actually I was reading the REST code (branch 0.2), opening a scanner, it checks if the columns are specified, and if not
// TODO: Need to put into the scanner all of the table's column
// families. TODO: Verify this returns all rows. For now just fail.
doMethodNotAllowed(response, "Unspecified columns parameter currently not supported!");
Are you sure the REST api allows it? Unless I'm looking at the wrong code.
The obvious way to do this is if it's null we get the columns list from the table.
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-889) The current Thrift API does not allow
a new scanner to be created without supplying a column list unlike the
other APIs.
Posted by "Tim Sell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632666#action_12632666 ]
Tim Sell commented on HBASE-889:
--------------------------------
Oops. I'm happy to look at this. I'll post a patch for 0.2.* and trunk in a jiffy.
There's probably at least few more little things like this in the thrift api.
> The current Thrift API does not allow a new scanner to be created without supplying a column list unlike the other APIs.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-889
> URL: https://issues.apache.org/jira/browse/HBASE-889
> Project: Hadoop HBase
> Issue Type: Bug
> Components: thrift
> Affects Versions: 0.2.0, 0.2.1
> Reporter: Charlie Mason
>
> The current Thrift API does not allow a new scanner to be created without supplying a column list, unlike the REST api. I posted this on the HBase-Users mailing list. Others concurred that it appears to have been an oversight in the Thrift API.
> Its quite significant as there is no easy work around, unless you already know which the column families names then list them all when you open the scanner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.