You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/04 22:52:49 UTC

[GitHub] [incubator-superset] etr2460 opened a new pull request #9241: [build] Bump superset-ui packages and update build

etr2460 opened a new pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [x] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Recently there's been some build config changes in the superset-ui repos, this pulls the new packages into Superset and updates the build to work appropriately
   
   ### TEST PLAN
   View a dashboard and see that charts still work as expected
   <img width="1920" alt="Screen Shot 2020-03-04 at 2 40 38 PM" src="https://user-images.githubusercontent.com/7409244/75929905-5b321b00-5e26-11ea-8e38-e2b3b458d666.png">
   
   ensure `npm run prod` and `npm run build` still work
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   to: @kristw @graceguo-supercat @rusackas @nytai 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#issuecomment-595455332
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=h1) Report
   > Merging [#9241](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/969bc87431264bb71462ca834b934fd295ed0650?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9241/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9241   +/-   ##
   =======================================
     Coverage   58.93%   58.93%           
   =======================================
     Files         373      373           
     Lines       12014    12014           
     Branches     2945     2945           
   =======================================
     Hits         7080     7080           
     Misses       4755     4755           
     Partials      179      179
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=footer). Last update [969bc87...5007640](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#issuecomment-595455332
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=h1) Report
   > Merging [#9241](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/969bc87431264bb71462ca834b934fd295ed0650?src=pr&el=desc) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9241/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #9241   +/-   ##
   =======================================
     Coverage   58.93%   58.93%           
   =======================================
     Files         373      373           
     Lines       12014    12014           
     Branches     2945     2945           
   =======================================
     Hits         7080     7080           
     Misses       4755     4755           
     Partials      179      179
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=footer). Last update [969bc87...6f3bb33](https://codecov.io/gh/apache/incubator-superset/pull/9241?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#discussion_r388579433
 
 

 ##########
 File path: superset-frontend/spec/javascripts/components/AnchorLink_spec.jsx
 ##########
 @@ -18,7 +18,7 @@
  */
 import React from 'react';
 import { shallow } from 'enzyme';
-import sinon from 'sinon';
+import { promiseTimeout } from '@superset-ui/core';
 
 Review comment:
   fair enough

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#discussion_r388577913
 
 

 ##########
 File path: superset-frontend/spec/javascripts/dashboard/components/FilterTooltipWrapper_spec.jsx
 ##########
 @@ -19,6 +19,7 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 import { Overlay, Tooltip } from 'react-bootstrap';
+import { promiseTimeout } from '@superset-ui/core';
 
 Review comment:
   ugh, yup. idk why a linter didn't catch this :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on issue #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
etr2460 commented on issue #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#issuecomment-594940207
 
 
   Yup, just saw that. Hopefully CI passes now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#discussion_r388580258
 
 

 ##########
 File path: superset-frontend/babel.config.js
 ##########
 @@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+module.exports = {
+  sourceMaps: true,
+  retainLines: true,
+  presets: [
+    '@babel/preset-react',
+    [
+      '@babel/preset-env',
+      {
+        useBuiltIns: 'usage',
+        corejs: 3,
+        loose: true,
+        shippedProposals: true,
+      },
+    ],
+  ],
+  plugins: [
+    'lodash',
+    '@babel/plugin-syntax-dynamic-import',
+    '@babel/plugin-proposal-class-properties',
+    'react-hot-loader/babel',
+    ['@babel/plugin-transform-runtime', { corejs: 3 }],
+  ],
+  env: {
+    test: {
 
 Review comment:
   comment added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kristw commented on a change in pull request #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#discussion_r388577535
 
 

 ##########
 File path: superset-frontend/spec/javascripts/components/AnchorLink_spec.jsx
 ##########
 @@ -18,7 +18,7 @@
  */
 import React from 'react';
 import { shallow } from 'enzyme';
-import sinon from 'sinon';
+import { promiseTimeout } from '@superset-ui/core';
 
 Review comment:
   Could use `async` pattern similar to other ones for consistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 merged pull request #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kristw commented on issue #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
kristw commented on issue #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#issuecomment-594933615
 
 
   Build error related to https://github.com/facebook/jest/issues/8660
   Perhaps remove `modules: false` from babel config according to one of the comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kristw commented on a change in pull request #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#discussion_r388577072
 
 

 ##########
 File path: superset-frontend/spec/javascripts/dashboard/components/FilterTooltipWrapper_spec.jsx
 ##########
 @@ -19,6 +19,7 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 import { Overlay, Tooltip } from 'react-bootstrap';
+import { promiseTimeout } from '@superset-ui/core';
 
 Review comment:
   Probably not needed if you are not using it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kristw edited a comment on issue #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
kristw edited a comment on issue #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#issuecomment-594933615
 
 
   @etr2460  Build error related to https://github.com/facebook/jest/issues/8660
   Perhaps remove `modules: false` from babel config according to one of the comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] williaster commented on a change in pull request #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
williaster commented on a change in pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#discussion_r388576845
 
 

 ##########
 File path: superset-frontend/babel.config.js
 ##########
 @@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+module.exports = {
+  sourceMaps: true,
+  retainLines: true,
+  presets: [
+    '@babel/preset-react',
+    [
+      '@babel/preset-env',
+      {
+        useBuiltIns: 'usage',
+        corejs: 3,
+        loose: true,
+        shippedProposals: true,
+      },
+    ],
+  ],
+  plugins: [
+    'lodash',
+    '@babel/plugin-syntax-dynamic-import',
+    '@babel/plugin-proposal-class-properties',
+    'react-hot-loader/babel',
+    ['@babel/plugin-transform-runtime', { corejs: 3 }],
+  ],
+  env: {
+    test: {
 
 Review comment:
   after all the pain of figuring this out, should we add comments for why the different test config is needed? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kristw commented on a change in pull request #9241: [build] Bump superset-ui packages and update build

Posted by GitBox <gi...@apache.org>.
kristw commented on a change in pull request #9241: [build] Bump superset-ui packages and update build
URL: https://github.com/apache/incubator-superset/pull/9241#discussion_r388577304
 
 

 ##########
 File path: superset-frontend/jest.config.js
 ##########
 @@ -17,6 +17,7 @@
  * under the License.
  */
 module.exports = {
+  timers: 'real',
 
 Review comment:
   not needed. default is `real`. I have tried removing and it works.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org