You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@locus.apache.org on 2000/08/09 22:47:07 UTC
cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c
trawick 00/08/09 13:47:06
Modified: src CHANGES
src/modules/standard mod_cern_meta.c
Log:
mod_cern_meta: fix broken file reading loop in scan_meta_file().
We checked the retcode from apr_fgets() improperly.
Submitted by: Rob Simonson <si...@us.ibm.com>
Reviewed by: Jeff Trawick
Revision Changes Path
1.196 +3 -0 apache-2.0/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /home/cvs/apache-2.0/src/CHANGES,v
retrieving revision 1.195
retrieving revision 1.196
diff -u -r1.195 -r1.196
--- CHANGES 2000/08/07 19:25:58 1.195
+++ CHANGES 2000/08/09 20:47:05 1.196
@@ -1,4 +1,7 @@
Changes with Apache 2.0a6
+ *) mod_cern_meta: fix broken file reading loop in scan_meta_file().
+ [Rob Simonson <si...@us.ibm.com>]
+
*) Get xlate builds working again. The apr renaming in 2.0a5 broke
APACHE_XLATE builds. [Jeff Trawick]
1.21 +1 -1 apache-2.0/src/modules/standard/mod_cern_meta.c
Index: mod_cern_meta.c
===================================================================
RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_cern_meta.c,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- mod_cern_meta.c 2000/08/06 22:38:23 1.20
+++ mod_cern_meta.c 2000/08/09 20:47:06 1.21
@@ -248,7 +248,7 @@
apr_table_t *tmp_headers;
tmp_headers = apr_make_table(r->pool, 5);
- while (apr_fgets(w, MAX_STRING_LEN - 1, f) != APR_SUCCESS) {
+ while (apr_fgets(w, MAX_STRING_LEN - 1, f) == APR_SUCCESS) {
/* Delete terminal (CR?)LF */