You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Praveen Adlakha <ad...@gmail.com> on 2016/01/02 18:12:15 UTC
Review Request 41852: Standardization of error handling in falcon
Server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41852/
-----------------------------------------------------------
Review request for Falcon.
Bugs: Falcon-1705
https://issues.apache.org/jira/browse/Falcon-1705
Repository: falcon-git
Description
-------
Standardization of error handling in falcon Server
Diffs
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0ea2e4e
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3
prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 41be13f
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java 8c5346f
prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089
prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java 85041f9
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java dfed5af
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 0c7786f
Diff: https://reviews.apache.org/r/41852/diff/
Testing
-------
[INFO] Apache Falcon ...................................... SUCCESS [05:13 min]
[INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 s]
[INFO] Checkstyle ......................................... SUCCESS [ 0.005 s]
[INFO] Build Tools ........................................ SUCCESS [ 0.009 s]
[INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 s]
[INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 s]
[INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 s]
[INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 s]
[INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 s]
[INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 s]
[INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 s]
[INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 s]
[INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 s]
[INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 s]
[INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 s]
[INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 s]
[INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 s]
[INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 s]
[INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 s]
[INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 s]
[INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 s]
[INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 s]
[INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 s]
[INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 s]
[INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 s]
[INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 s]
[INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 s]
[INFO] falcon-unit ........................................ SUCCESS [ 0.016 s]
[INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 s]
[INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:17 min
[INFO] Finished at: 2016-01-02T22:02:42+05:30
[INFO] Final Memory: 598M/1415M
Thanks,
Praveen Adlakha
Re: Review Request 41852: Standardization of error handling in falcon
Server
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41852/#review112493
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/FalconWebException.java
<https://reviews.apache.org/r/41852/#comment172940>
This method was specifically introduced, because the top level exception most often did not contain the actual cause of exception. Please don't remove it.
Instead, you could introduce a method that takes in an exception and uses this method to get the message.
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 148)
<https://reviews.apache.org/r/41852/#comment172941>
As mentioned above, in such cases, we could just use FalconWebException.newAPIException(Throwable t)
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 1125)
<https://reviews.apache.org/r/41852/#comment172942>
Why was BAD_REQUEST changed to INTERNAL_SERVER_ERROR? Looks like it is a bad request, as it is an IllegalArgumentException
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 1128)
<https://reviews.apache.org/r/41852/#comment172943>
INTERNAL_SERVER_ERROR has become BAD_REQUEST.
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java (line 224)
<https://reviews.apache.org/r/41852/#comment172944>
As mentioned in my previous comment, you could add a new method, FalconWebException.newAPIException(Throwable t, Status status);
- Pallavi Rao
On Jan. 2, 2016, 5:12 p.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41852/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 5:12 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: Falcon-1705
> https://issues.apache.org/jira/browse/Falcon-1705
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Standardization of error handling in falcon Server
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0ea2e4e
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3
> prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 41be13f
> prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java 8c5346f
> prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089
> prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java 85041f9
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java dfed5af
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 0c7786f
>
> Diff: https://reviews.apache.org/r/41852/diff/
>
>
> Testing
> -------
>
> [INFO] Apache Falcon ...................................... SUCCESS [05:13 min]
> [INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 s]
> [INFO] Checkstyle ......................................... SUCCESS [ 0.005 s]
> [INFO] Build Tools ........................................ SUCCESS [ 0.009 s]
> [INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 s]
> [INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 s]
> [INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 s]
> [INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 s]
> [INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 s]
> [INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 s]
> [INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 s]
> [INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 s]
> [INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 s]
> [INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 s]
> [INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 s]
> [INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 s]
> [INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 s]
> [INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 s]
> [INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 s]
> [INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 s]
> [INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 s]
> [INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 s]
> [INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 s]
> [INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 s]
> [INFO] falcon-unit ........................................ SUCCESS [ 0.016 s]
> [INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 s]
> [INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 05:17 min
> [INFO] Finished at: 2016-01-02T22:02:42+05:30
> [INFO] Final Memory: 598M/1415M
>
>
> Thanks,
>
> Praveen Adlakha
>
>
Re: Review Request 41852: Standardization of error handling in falcon
Server
Posted by Praveen Adlakha <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41852/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 7:04 a.m.)
Review request for Falcon.
Bugs: Falcon-1705
https://issues.apache.org/jira/browse/Falcon-1705
Repository: falcon-git
Description
-------
Standardization of error handling in falcon Server
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0ea2e4e
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3
prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 41be13f
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java 8c5346f
prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089
prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java 85041f9
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java dfed5af
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 0c7786f
Diff: https://reviews.apache.org/r/41852/diff/
Testing
-------
[INFO] Apache Falcon ...................................... SUCCESS [05:13 min]
[INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 s]
[INFO] Checkstyle ......................................... SUCCESS [ 0.005 s]
[INFO] Build Tools ........................................ SUCCESS [ 0.009 s]
[INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 s]
[INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 s]
[INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 s]
[INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 s]
[INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 s]
[INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 s]
[INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 s]
[INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 s]
[INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 s]
[INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 s]
[INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 s]
[INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 s]
[INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 s]
[INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 s]
[INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 s]
[INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 s]
[INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 s]
[INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 s]
[INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 s]
[INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 s]
[INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 s]
[INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 s]
[INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 s]
[INFO] falcon-unit ........................................ SUCCESS [ 0.016 s]
[INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 s]
[INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:17 min
[INFO] Finished at: 2016-01-02T22:02:42+05:30
[INFO] Final Memory: 598M/1415M
Thanks,
Praveen Adlakha
Re: Review Request 41852: Standardization of error handling in falcon
Server
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41852/#review113011
-----------------------------------------------------------
Ship it!
Good to go once you have addressed the minor refactor pointed out.
prism/src/main/java/org/apache/falcon/FalconWebException.java (line 57)
<https://reviews.apache.org/r/41852/#comment173493>
This method can call newAPIException(message, status) with BAD_REQUEST as status
- Pallavi Rao
On Jan. 5, 2016, 7:40 p.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41852/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: Falcon-1705
> https://issues.apache.org/jira/browse/Falcon-1705
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Standardization of error handling in falcon Server
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0ea2e4e
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3
> prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 41be13f
> prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java 8c5346f
> prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089
> prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java 85041f9
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java dfed5af
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 0c7786f
>
> Diff: https://reviews.apache.org/r/41852/diff/
>
>
> Testing
> -------
>
> [INFO] Apache Falcon ...................................... SUCCESS [05:13 min]
> [INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 s]
> [INFO] Checkstyle ......................................... SUCCESS [ 0.005 s]
> [INFO] Build Tools ........................................ SUCCESS [ 0.009 s]
> [INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 s]
> [INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 s]
> [INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 s]
> [INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 s]
> [INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 s]
> [INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 s]
> [INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 s]
> [INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 s]
> [INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 s]
> [INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 s]
> [INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 s]
> [INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 s]
> [INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 s]
> [INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 s]
> [INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 s]
> [INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 s]
> [INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 s]
> [INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 s]
> [INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 s]
> [INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 s]
> [INFO] falcon-unit ........................................ SUCCESS [ 0.016 s]
> [INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 s]
> [INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 05:17 min
> [INFO] Finished at: 2016-01-02T22:02:42+05:30
> [INFO] Final Memory: 598M/1415M
>
>
> Thanks,
>
> Praveen Adlakha
>
>
Re: Review Request 41852: Standardization of error handling in falcon
Server
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41852/#review113004
-----------------------------------------------------------
Ship it!
prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java (line 168)
<https://reviews.apache.org/r/41852/#comment173488>
This will fail checkstyle. case statement should be at same indentation as switch.
- Ajay Yadava
On Jan. 5, 2016, 7:40 p.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41852/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 7:40 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: Falcon-1705
> https://issues.apache.org/jira/browse/Falcon-1705
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Standardization of error handling in falcon Server
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0ea2e4e
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3
> prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 41be13f
> prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java 8c5346f
> prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089
> prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java 85041f9
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java dfed5af
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 0c7786f
>
> Diff: https://reviews.apache.org/r/41852/diff/
>
>
> Testing
> -------
>
> [INFO] Apache Falcon ...................................... SUCCESS [05:13 min]
> [INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 s]
> [INFO] Checkstyle ......................................... SUCCESS [ 0.005 s]
> [INFO] Build Tools ........................................ SUCCESS [ 0.009 s]
> [INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 s]
> [INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 s]
> [INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 s]
> [INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 s]
> [INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 s]
> [INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 s]
> [INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 s]
> [INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 s]
> [INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 s]
> [INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 s]
> [INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 s]
> [INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 s]
> [INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 s]
> [INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 s]
> [INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 s]
> [INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 s]
> [INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 s]
> [INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 s]
> [INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 s]
> [INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 s]
> [INFO] falcon-unit ........................................ SUCCESS [ 0.016 s]
> [INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 s]
> [INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 05:17 min
> [INFO] Finished at: 2016-01-02T22:02:42+05:30
> [INFO] Final Memory: 598M/1415M
>
>
> Thanks,
>
> Praveen Adlakha
>
>
Re: Review Request 41852: Standardization of error handling in falcon
Server
Posted by Praveen Adlakha <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41852/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 7:40 p.m.)
Review request for Falcon.
Bugs: Falcon-1705
https://issues.apache.org/jira/browse/Falcon-1705
Repository: falcon-git
Description
-------
Standardization of error handling in falcon Server
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0ea2e4e
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3
prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 41be13f
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java 8c5346f
prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089
prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java 85041f9
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java dfed5af
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 0c7786f
Diff: https://reviews.apache.org/r/41852/diff/
Testing
-------
[INFO] Apache Falcon ...................................... SUCCESS [05:13 min]
[INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 s]
[INFO] Checkstyle ......................................... SUCCESS [ 0.005 s]
[INFO] Build Tools ........................................ SUCCESS [ 0.009 s]
[INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 s]
[INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 s]
[INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 s]
[INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 s]
[INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 s]
[INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 s]
[INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 s]
[INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 s]
[INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 s]
[INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 s]
[INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 s]
[INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 s]
[INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 s]
[INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 s]
[INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 s]
[INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 s]
[INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 s]
[INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 s]
[INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 s]
[INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 s]
[INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 s]
[INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 s]
[INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 s]
[INFO] falcon-unit ........................................ SUCCESS [ 0.016 s]
[INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 s]
[INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:17 min
[INFO] Finished at: 2016-01-02T22:02:42+05:30
[INFO] Final Memory: 598M/1415M
Thanks,
Praveen Adlakha
Re: Review Request 41852: Standardization of error handling in falcon
Server
Posted by Praveen Adlakha <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41852/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 7:36 p.m.)
Review request for Falcon.
Bugs: Falcon-1705
https://issues.apache.org/jira/browse/Falcon-1705
Repository: falcon-git
Description
-------
Standardization of error handling in falcon Server
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0ea2e4e
prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111
prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3
prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 41be13f
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java 8c5346f
prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089
prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java 85041f9
prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java dfed5af
webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 0c7786f
Diff: https://reviews.apache.org/r/41852/diff/
Testing
-------
[INFO] Apache Falcon ...................................... SUCCESS [05:13 min]
[INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 s]
[INFO] Checkstyle ......................................... SUCCESS [ 0.005 s]
[INFO] Build Tools ........................................ SUCCESS [ 0.009 s]
[INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 s]
[INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 s]
[INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 s]
[INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 s]
[INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 s]
[INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 s]
[INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 s]
[INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 s]
[INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 s]
[INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 s]
[INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 s]
[INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 s]
[INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 s]
[INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 s]
[INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 s]
[INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 s]
[INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 s]
[INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 s]
[INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 s]
[INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 s]
[INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 s]
[INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 s]
[INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 s]
[INFO] falcon-unit ........................................ SUCCESS [ 0.016 s]
[INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 s]
[INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 05:17 min
[INFO] Finished at: 2016-01-02T22:02:42+05:30
[INFO] Final Memory: 598M/1415M
Thanks,
Praveen Adlakha
Re: Review Request 41852: Standardization of error handling in falcon
Server
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41852/#review112604
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/FalconWebException.java
<https://reviews.apache.org/r/41852/#comment173103>
+1 to Pallavi Rao's suggestion.
prism/src/main/java/org/apache/falcon/FalconWebException.java (line 56)
<https://reviews.apache.org/r/41852/#comment173104>
You will need to put space after comma otherwise it will fail checkstyle checks.
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 148)
<https://reviews.apache.org/r/41852/#comment173102>
I agree with Pallavi Rao here, we should have one more overloaded version of newAPIException which just takes a throwable and sets the status to BAD_REQUEST by default.
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 1125)
<https://reviews.apache.org/r/41852/#comment173106>
There should be one more overloaded version of
FalconWebException.newAPIException(Throwable t, Response.Status status) which can be used for such scenarios.
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 1128)
<https://reviews.apache.org/r/41852/#comment173105>
There should be one more overloaded version of
FalconWebException.newAPIException(Throwable t, Response.Status status) which can be used for such scenarios.
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java (line 224)
<https://reviews.apache.org/r/41852/#comment173107>
+1 to Pallavi Rao's suggestion.
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java (line 429)
<https://reviews.apache.org/r/41852/#comment173108>
space after comma
prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java (line 461)
<https://reviews.apache.org/r/41852/#comment173109>
space after comma.
prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java (line 232)
<https://reviews.apache.org/r/41852/#comment173110>
Not introduced in this JIRA, but a better message in this case would be: "Unable to parse entity definition"
Before uploading the patch you can check for all the checkstyle issues using the following command - mvn clean install -Ptest-patch,hadoop-2
- Ajay Yadava
On Jan. 2, 2016, 5:12 p.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41852/
> -----------------------------------------------------------
>
> (Updated Jan. 2, 2016, 5:12 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: Falcon-1705
> https://issues.apache.org/jira/browse/Falcon-1705
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Standardization of error handling in falcon Server
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/FalconWebException.java 0b6c38e
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 0ea2e4e
> prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111
> prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3
> prism/src/main/java/org/apache/falcon/resource/channel/HTTPChannel.java 41be13f
> prism/src/main/java/org/apache/falcon/resource/metadata/LineageMetadataResource.java 8c5346f
> prism/src/main/java/org/apache/falcon/resource/metadata/MetadataDiscoveryResource.java 60c1089
> prism/src/main/java/org/apache/falcon/resource/proxy/BufferedRequest.java 85041f9
> prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10
> prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java dfed5af
> webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java 0c7786f
>
> Diff: https://reviews.apache.org/r/41852/diff/
>
>
> Testing
> -------
>
> [INFO] Apache Falcon ...................................... SUCCESS [05:13 min]
> [INFO] Apache Falcon UI ................................... SUCCESS [ 0.027 s]
> [INFO] Checkstyle ......................................... SUCCESS [ 0.005 s]
> [INFO] Build Tools ........................................ SUCCESS [ 0.009 s]
> [INFO] Apache Falcon Java client .......................... SUCCESS [ 0.095 s]
> [INFO] Apache Falcon CLI client ........................... SUCCESS [ 0.012 s]
> [INFO] Apache Falcon Metrics .............................. SUCCESS [ 0.013 s]
> [INFO] Apache Falcon Hadoop Dependencies .................. SUCCESS [ 0.027 s]
> [INFO] Apache Falcon Test Utility ......................... SUCCESS [ 0.009 s]
> [INFO] Apache Falcon Commons .............................. SUCCESS [ 0.100 s]
> [INFO] Apache Falcon Oozie EL Extension ................... SUCCESS [ 0.015 s]
> [INFO] Apache Falcon Embedded Hadoop - Test Cluster ....... SUCCESS [ 0.077 s]
> [INFO] Apache Falcon Sharelib Hive - Test Cluster ......... SUCCESS [ 0.006 s]
> [INFO] Apache Falcon Sharelib Pig - Test Cluster .......... SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Sharelib Hcatalog - Test Cluster ..... SUCCESS [ 0.006 s]
> [INFO] Apache Falcon Sharelib Oozie - Test Cluster ........ SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Test Tools - Test Cluster ............ SUCCESS [ 0.003 s]
> [INFO] Apache Falcon Messaging ............................ SUCCESS [ 0.018 s]
> [INFO] Apache Falcon LIfecycle Module ..................... SUCCESS [ 0.072 s]
> [INFO] Apache Falcon Oozie Adaptor ........................ SUCCESS [ 0.066 s]
> [INFO] Apache Falcon Scheduler ............................ SUCCESS [ 0.061 s]
> [INFO] Apache Falcon Acquisition .......................... SUCCESS [ 0.012 s]
> [INFO] Apache Falcon Distcp Replication ................... SUCCESS [ 0.013 s]
> [INFO] Apache Falcon Retention ............................ SUCCESS [ 0.008 s]
> [INFO] Apache Falcon Archival ............................. SUCCESS [ 0.007 s]
> [INFO] Apache Falcon Rerun ................................ SUCCESS [ 0.019 s]
> [INFO] Apache Falcon Prism ................................ SUCCESS [ 0.623 s]
> [INFO] falcon-unit ........................................ SUCCESS [ 0.016 s]
> [INFO] Apache Falcon Web Application ...................... SUCCESS [ 0.165 s]
> [INFO] Apache Falcon Documentation ........................ SUCCESS [ 0.025 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 05:17 min
> [INFO] Finished at: 2016-01-02T22:02:42+05:30
> [INFO] Final Memory: 598M/1415M
>
>
> Thanks,
>
> Praveen Adlakha
>
>