svn commit: r951065 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

[mm...@apache.org]

Author: mmartinec
Date: Thu Jun  3 16:48:30 2010
New Revision: 951065

URL: http://svn.apache.org/viewvc?rev=951065&view=rev
Log:
Bug 5491: MIME_QP_LONG_LINE triggering on valid email:
change a QP line limit from 76 to 78

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm?rev=951065&r1=951064&r2=951065&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/MIMEEval.pm Thu Jun  3 16:48:30 2010
@@ -296,7 +296,16 @@ sub _check_attachments {
       }
 
       if ($where != 1 && $cte eq "quoted-printable" && ! /^SPAM: /) {
-        if (length > 77) {
+        # RFC 5322: Each line SHOULD be no more than 78 characters,
+        #           excluding the CRLF
+        # RFC 2045: The Quoted-Printable encoding REQUIRES that
+        #           encoded lines be no more than 76 characters long.
+        # Bug 5491: 6% of email classified as HAM by SA triggered the
+        #           MIME_QP_LONG_LINE rule. Apple Mail can generate a QP-line
+        #           that is 2 chars too long. Same goes for Outlook Web Access.
+        # lines include one trailing \n character
+      # if (length > 76+1) {  # conforms to RFC 5322 and RFC 2045
+        if (length > 78+1) {  # conforms to RFC 5322 only, not RFC 2045
 	  $pms->{mime_qp_long_line} = 1;
         }
         $qp_bytes += length;