[GitHub] [karaf] awrb commented on a diff in pull request #1649: [KARAF-6319] - add option to assembly mojo

[GitBox <gi...@apache.org>]

awrb commented on code in PR #1649:
URL: https://github.com/apache/karaf/pull/1649#discussion_r994179616


##########
manual/src/main/asciidoc/developer-guide/karaf-maven-plugin.adoc:
##########
@@ -471,6 +471,9 @@ The `karaf:assembly` goal creates a Karaf instance (assembly) filesystem using t
                     <installedBundles>
                         <installedBundle>${additional.bundle}</installedBundle>
                     </installedBundles>
+                    <prerequisiteFeatures>
+                        <feature>ssh</feature>

Review Comment:
   I used this name because it's already used in `GenerateDescriptorMojo`:
   ```
       /**
        * Name of features which are prerequisites (they still need to be defined separately).
        */
       @Parameter
       private List<String> prerequisiteFeatures = new ArrayList<>();
   ```
   also in provisioning.adoc:
   ```
   ===== Feature prerequisites
   
   A prerequisite feature is a special kind of dependency. If you add the `prerequisite` attribute to dependant feature tag then it will force installation and also activation of bundles in the dependant feature before the installation of the actual feature. This may be handy in the case that bundles enlisted in a given feature are not using pre installed URLs such as `wrap` or `war`.
   
   ----
   <feature name="foo" version="1.0.0">
       <feature prerequisite="true">bar</feature>
       ...
   </feature>
   ----
   ```
   so that was my thought process. I am happy to change it though, `firstStageBootFeatures` is nice as it contains the stage name.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org