You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2023/11/30 19:32:21 UTC
(pinot) branch master updated: Fix bug with silently ignoring force commit call failures (#12044)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 88fcd0e4ee Fix bug with silently ignoring force commit call failures (#12044)
88fcd0e4ee is described below
commit 88fcd0e4ee9853520f225e76c0775d7cdd24125e
Author: Aidar Bariev <ai...@stripe.com>
AuthorDate: Thu Nov 30 11:32:15 2023 -0800
Fix bug with silently ignoring force commit call failures (#12044)
---
.../pinot/controller/api/resources/PinotRealtimeTableResource.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java
index 404e7553db..0cae40082d 100644
--- a/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java
+++ b/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java
@@ -148,8 +148,10 @@ public class PinotRealtimeTableResource {
response.put("forceCommitStatus", "SUCCESS");
try {
String jobId = UUID.randomUUID().toString();
- _pinotHelixResourceManager.addNewForceCommitJob(tableNameWithType, jobId, startTimeMs,
- consumingSegmentsForceCommitted);
+ if (!_pinotHelixResourceManager.addNewForceCommitJob(tableNameWithType, jobId, startTimeMs,
+ consumingSegmentsForceCommitted)) {
+ throw new IllegalStateException("Failed to update table jobs ZK metadata");
+ }
response.put("jobMetaZKWriteStatus", "SUCCESS");
response.put("forceCommitJobId", jobId);
} catch (Exception e) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org